Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Nov 2018 08:45:39 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Tadeusz Struk <tadeusz.struk@intel.com>
Cc:     jgg@ziepe.ca, linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] tpm: add support for partial reads
Message-ID: <20181121064539.GB3640@linux.intel.com>
References: <154265371562.23494.10113870855345906523.stgit@tstruk-mobl1.jf.intel.com>
 <20181120124810.GB8813@linux.intel.com>
 <77b031b2-7fa2-f057-1e6a-70f0427ec6c4@intel.com>
 <20181120230759.GF8391@linux.intel.com>
 <affa9788-9d86-341f-28fb-66a8720ef697@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <affa9788-9d86-341f-28fb-66a8720ef697@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 20, 2018 at 03:13:59PM -0800, Tadeusz Struk wrote:
> On 11/20/18 3:07 PM, Jarkko Sakkinen wrote:
> >>>> +	/* Holds the resul of the last successful call to tpm_transmit() */
> >>> This comment is cruft.
> >> Do you want me to remove it? This is the comment you proposed.
> > As I explained before it made sense before you made the remark that
> > it can only get positive values i.e. the length.
> > 
> So what do you want me to do with this one?

I don't think it needs now any comment because the variable describes
itself so well.

/Jarkko