Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Nicolas Boichat <drinkcat@chromium.org>,
        Weiyi Lu <weiyi.lu@mediatek.com>
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <1542681454.5132.9.camel@mtksdaap41>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>, sboyd@codeaurora.org,
        Rob Herring <robh@kernel.org>, jamesjj.liao@mediatek.com,
        fan.chen@mediatek.com,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        lkml <linux-kernel@vger.kernel.org>,
        linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
        srv_heupstream@mediatek.com, owen.chen@mediatek.com,
        mars.cheng@mediatek.com
References: <20181106064206.17535-1-weiyi.lu@mediatek.com>
 <20181106064206.17535-6-weiyi.lu@mediatek.com>
 <CANMq1KDbauouMDvsZS3KsNJrNs1gGg7mDjsKRw=zTcuQXSTa0Q@mail.gmail.com>
 <1542681454.5132.9.camel@mtksdaap41>
Message-ID: <154278766192.88331.16232130563413450456@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH v1 04/11] soc: mediatek: add new flow for mtcmos power.
Date:   Wed, 21 Nov 2018 00:07:41 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Weiyi Lu (2018-11-19 18:37:34)
> On Tue, 2018-11-13 at 11:31 -0800, Nicolas Boichat wrote:
> > On Mon, Nov 5, 2018 at 10:42 PM Weiyi Lu <weiyi.lu@mediatek.com> wrote:

> > > @@ -226,6 +397,7 @@ static int scpsys_power_on(struct generic_pm_doma=
in *genpd)
> > >         if (ret < 0)
> > >                 goto err_pwr_ack;
> > >
> > > +
> > =

> > Drop this.
> Why do we try to drop this? Once the power-on step fail, the following
> steps should not be permitted.

I just see a whitespace addition that doesn't do anything. I suspect
it's a style nitpick and common practice to not include spurious diffs
in the patch. So remove this hunk?