Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1762587imu; Wed, 21 Nov 2018 01:21:45 -0800 (PST) X-Google-Smtp-Source: AFSGD/XJylAHpRol35JB+z1P9+3/WVgF55UJJSrLix5nbYzmYYYpiW08E3wh4ee3QTy66mULPyjl X-Received: by 2002:a63:3703:: with SMTP id e3mr5159166pga.348.1542792104993; Wed, 21 Nov 2018 01:21:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542792104; cv=none; d=google.com; s=arc-20160816; b=e0vywKR82ciH+kr8lSTfvQ16hUz0cUSbgV3m+DwPYG1Cn+VaQSiN/p/3Btx8nGEYP0 WNA2RegepTuSk4lP4VqJglBifc5hL0uHx/dG2pBTzpKKKhsLHG1HwJhgDJ+N8RYr8xpM iKiGr30oIf9GQy61qPQUaU420QawyVnT0qA19r51JbKb4enP/qe4Elb/zv/0E/p0N6Gh fo3kG/EPaQowwEOoajd80Ojq9OTQ8axxy0LDtwCuDP21zeL2uv856IwMTCq1x+U1WGI8 /gXGy8wrn+XzGHFWdFQmlgjQC7PeXFAS8cw1ChntR37RiHcOFa96aYdP1OB8dFLYqf30 sjkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9Od011HKcMAp9G7y/qSJgDzDxUdghRQK7R9VpPQ1O2o=; b=eUQNU8+o7/pX+gdblJijB/gMXmc3At+Imf+gWmfPxuNIMGlpPTv5kK/EkpPXo4MU7D qpkBeZJwrbH1doeS/hdvCMEMLwau4z2OvkJY+sxGrsNX/qF8Yju6WPTs0QxuDd4QtR6X B/frkQT/kwiqsXE5AkYz5dd0zxsgVDOy0+nVGIGUE/UUzWOWevBxIV1L/cPoWZcai5YC 0/RKZ4eKG3VQP3UYl9533FG3CopI0TJpGOo6eNHBgV5bFhWkhUakavvGLQI/hO3Rmvma YfdSEQghaXfnDlgkrjly0CesFhtglpSIeKtpxYCfJiFlC58dmoLmUa7dWWR/Olh84viX VJJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SJFkUorY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p64si22390587pfg.79.2018.11.21.01.21.29; Wed, 21 Nov 2018 01:21:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SJFkUorY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbeKUSKR (ORCPT + 99 others); Wed, 21 Nov 2018 13:10:17 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:33702 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726246AbeKUSKQ (ORCPT ); Wed, 21 Nov 2018 13:10:16 -0500 Received: by mail-lj1-f196.google.com with SMTP id v1-v6so3949243ljd.0 for ; Tue, 20 Nov 2018 23:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9Od011HKcMAp9G7y/qSJgDzDxUdghRQK7R9VpPQ1O2o=; b=SJFkUorYyUToroQdjHp8eFcCcUdZhZ9xg9QDZJvOfij6+G4n+tcRGFUxTPmo+7PsJP GMkmz59jXlUKJLmhmvomMvo+B5MWmQR8LlkUfCpCGXQb3lfEGXvwgkVczwb/SXfUabZ3 DH0eg4T+NzOQx6YhKRNL+t/uv2hEhKrIFuwtc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9Od011HKcMAp9G7y/qSJgDzDxUdghRQK7R9VpPQ1O2o=; b=Y+IvhApcS9UmVKUuLNjM7cZclI2GG/S6Wx5ssS35KtrCU2kLc+IDeJX0mwafBAv+KZ VAt3MJUJcoM2YWNXXbXtPk5wR4SUR599YV/BnaPEKkry0fJxW09s/4nKroamZK1cmSEV PGUSxb9mzFNEQxl6n7WcDAacpTSyL4m2w/lqjIfwOC5FtOP+R0UgKsuKP6LA3CUAyNrN D8gfnAkm5BFJby4y1efiF0sl/pPJFvOr1wJcoEAZ2Q0bp9diM0t/XhbF0OgEIOBZYS82 3U95aH1SkGbEn1LeJqG9ny7jC091h+UT7HciZbihr1lheJFO/kcHM0lAqovkagdb7SeB NFQA== X-Gm-Message-State: AA+aEWafNlKsFDdecCo5yacDWmgeifVhW8/VvgNNWl2JCXLaU/SrH2HZ z1HB57sjqm/WezA9OpOMgS2cyNbuReU= X-Received: by 2002:a2e:9849:: with SMTP id e9-v6mr1872793ljj.9.1542785812134; Tue, 20 Nov 2018 23:36:52 -0800 (PST) Received: from jax.urgonet (h-84-105.A175.priv.bahnhof.se. [79.136.84.105]) by smtp.gmail.com with ESMTPSA id k11-v6sm3363385ljk.40.2018.11.20.23.36.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 23:36:51 -0800 (PST) Date: Wed, 21 Nov 2018 08:36:49 +0100 From: Jens Wiklander To: Victor Chong Cc: tee-dev@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] tee: optee: log message if dynamic shm is enabled Message-ID: <20181121073648.GA20049@jax.urgonet> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Victor, On Tue, Sep 11, 2018 at 06:09:02PM +0900, Victor Chong wrote: > When dynamic shared memory support is enabled in the OP-TEE Trusted > OS, it doesn't mean that the driver supports it, which can confuse > users during debugging. Log a message when dynamic shared memory is > enabled in the driver, to let users know for sure. > > Suggested-by: Jerome Forissier > Signed-off-by: Victor Chong > Reviewed-by: Jerome Forissier > --- > > v2: > * Added patch description > > [v1] lore.kernel.org/patchwork/patch/983949/ > > drivers/tee/optee/core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > index e1aafe842d66..cca5c091e55a 100644 > --- a/drivers/tee/optee/core.c > +++ b/drivers/tee/optee/core.c > @@ -631,6 +631,9 @@ static struct optee *optee_probe(struct device_node *np) > > optee_enable_shm_cache(optee); > > + if (optee->sec_caps & OPTEE_SMC_SEC_CAP_DYNAMIC_SHM) > + pr_info("dynamic shared memory is enabled\n"); > + > pr_info("initialized driver\n"); > return optee; > err: > -- > 2.17.1 Looks good. I'm picking this up. Thanks, Jens