Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Nov 2018 10:40:17 +0100
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Maxime Ripard <maxime.ripard@bootlin.com>
Cc:     Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        Boris Brezillon <boris.brezillon@bootlin.com>,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Sean Paul <sean@poorly.run>
Subject: Re: [PATCH] drm/fb-helper: Blacklist writeback when adding
 connectors to fbdev
Message-ID: <20181121094017.GM4266@phenom.ffwll.local>
Mail-Followup-To: Maxime Ripard <maxime.ripard@bootlin.com>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        Boris Brezillon <boris.brezillon@bootlin.com>,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Sean Paul <sean@poorly.run>
References: <20181115163248.21168-1-paul.kocialkowski@bootlin.com>
 <20181119092835.3y2xqfclwlmk4cww@flea>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181119092835.3y2xqfclwlmk4cww@flea>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 19, 2018 at 10:28:35AM +0100, Maxime Ripard wrote:
> On Thu, Nov 15, 2018 at 05:32:48PM +0100, Paul Kocialkowski wrote:
> > Writeback connectors do not produce any on-screen output and require
> > special care for use. Such connectors are hidden from enumeration in
> > DRM resources by default, but they are still picked-up by fbdev.
> > This makes rather little sense since fbdev is not really adapted for
> > dealing with writeback.
> > 
> > Moreover, this is also a source of issues when userspace disables the
> > CRTC (and associated plane) without detaching the CRTC from the
> > connector (which is hidden by default). In this case, the connector is
> > still using the CRTC, leading to am "enabled/connectors mismatch" and
> > eventually the failure of the associated atomic commit. This situation
> > happens with VC4 testing under IGT GPU Tools.
> > 
> > Filter out writeback connectors in the fbdev helper to solve this.
> > 
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> 
> Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
> Tested-by: Maxime Ripard <maxime.ripard@bootlin.com>

Applied with a cc: stable to drm-misc-fixes. Btw, 2 r-b from committers,
someone should have pushed this I think :-)

Thanks for patch&review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch