Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1869949imu; Wed, 21 Nov 2018 03:18:19 -0800 (PST) X-Google-Smtp-Source: AFSGD/VyC1SsqWwLEER+YshUj1PTgISKVU3Ry0qSpXn6Aq94R4MYeueq1k1Yz8DSQYrXKjN9d6Fa X-Received: by 2002:a63:f65:: with SMTP id 37mr5522404pgp.238.1542799099479; Wed, 21 Nov 2018 03:18:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542799099; cv=none; d=google.com; s=arc-20160816; b=nrSMWyjWNIQU2+BHrX8YEPmKCRFXdehgVb4uVnZipRckR4o/tQy1FxAxuh+v8QQnqm z6ZR/4mpi30GjI6+DmZogo2dWRX9cbslomq15E68UEjfmTq39ch+tK1ysogyO4l7r71G saWx5qCyNRqMux9LDiISf13UdMg3k4/HE66I48ziICHX8zjnltLpGlhvaKSnzxCX6szE c+X3xqW9Sba8gEZ0yTDphfLcVq/J0nltW8ba/Xte7at1XGb69ng+6KHIJZAVJKs9bpb9 QMe/zifTtQdoqa8C1bVQaPw3on3gGwxHf3el0Ihh6a2CLV/8XL1a8jr02+VgUyoz3fZT 1lUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=GcpuiqvcOi12dA9QKswSj7PacHSaMlFclPBzGn+KxXM=; b=00wIjk2iOlyE5Z8ZGqVW6Uuc/tth0Sw3ZKNyEySuPwJ0laq/VHD0nHqZq9dOjQNWVL jqLer4aFtvIZY9VlPP/FIeAoTGjQ4r2K3cyw5yW+RN498szv5sdIAo958u21LNJA60kt KcH6e2GT86PyEhOGK6waP5XhZhNowhTDwSpWRJ87ua+iPZVykewC8TdTFbbGmTQ6xmRP In3MrQNrrtH17eZFn3HbRWiD8y4ZmJXYBEiGvjQjDuxrUEp6eCmMal5cTlIqd/asFuwx 5fAXkJAGu/dEzgg9EH9YV38Pd2cLCZI6iCRWtChEUp+euLfURpQWzAM20Oo5C9J5+QrC dSMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f38si45169469pgf.206.2018.11.21.03.18.05; Wed, 21 Nov 2018 03:18:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729902AbeKUUuc convert rfc822-to-8bit (ORCPT + 99 others); Wed, 21 Nov 2018 15:50:32 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:61200 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726016AbeKUUuc (ORCPT ); Wed, 21 Nov 2018 15:50:32 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 14579409-1500050 for multiple; Wed, 21 Nov 2018 10:16:31 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: David Airlie , Hans Holmberg From: Chris Wilson In-Reply-To: <20181121095423.20760-1-hans.ml.holmberg@owltronix.com> Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hans Holmberg References: <20181121095423.20760-1-hans.ml.holmberg@owltronix.com> Message-ID: <154279538801.11623.10312467957931830687@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates Date: Wed, 21 Nov 2018 10:16:28 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Hans Holmberg (2018-11-21 09:54:23) > From: Hans Holmberg > > There is no need to rebuild i915_gpu_error.o when the version string > changes as the version is available in init_utsname()->release. > > Signed-off-by: Hans Holmberg > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 8762d17b6659..958e1484a3dd 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -27,7 +27,7 @@ > * > */ > > -#include > +#include > #include > #include > #include > @@ -650,7 +650,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m, > > if (*error->error_msg) > err_printf(m, "%s\n", error->error_msg); > - err_printf(m, "Kernel: " UTS_RELEASE "\n"); > + err_printf(m, "Kernel: %s\n", init_utsname()->release); Should we take some more info from init_utsname, plagiarising dump_stack, err_printf(m, :Kernel: %s %.*s\n", init_utsname()->release, (int)strcspn(init_utsname()->version, " "), init_utsname()->version); -Chris