Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1933682imu; Wed, 21 Nov 2018 04:20:47 -0800 (PST) X-Google-Smtp-Source: AJdET5ezBuBxe9htFZVt5h2n9uK+h/phULAfNZGBwCfN4n3u3UFzBPTu15V/fnntbz5BMqB+vs18 X-Received: by 2002:a62:5e46:: with SMTP id s67-v6mr6809269pfb.122.1542802847906; Wed, 21 Nov 2018 04:20:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542802847; cv=none; d=google.com; s=arc-20160816; b=jhF6oXt1YjPazQCulCq47OGlKph61dWU5sAqKdcYYqDpnFo+i03C0P3DUTswjPxcrC wttCLqVOexLwsC7MUS3rNAEvE40yJZcaWNyr3AYAstFA/3WxrM6bAlNBF18tFXs9lA7J Q136xpR/p96fQwRO9ZYJtk1EG9l3Dj0iamrk8nhmZ1TMYlQQuXOODLu3w9FTfAEdrBze +PhwzOK9GUnz0mlu6DFpJaU2BOoPzbzDkfZ5oa/+2+40ZPZYiwWOsxoiHLzu9/Gu8+kK 6zpcsVWMD+p3j3wks9hGGFSiEfH3gwdSyED6evIJFYBM8ODFAh+X9V90sta48+JyFFoW 5tuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GWr93rI5vOjJXu1utLg01PpRQmImuvJaHVDucwXozd0=; b=DTnBgmEEaBeBNGnotJt53qfzo6fxzo0TatqzdTwJrHcRxwjiy6pxejTAkGIciKVusR 9QH7ITUHqx3nfJG58iVdOhw/LhZuWeyGpyflsYgoXL7/h+kWTkyST68WVj7WqOMEe4q6 H//OF+iECeVxNjUzYdqMOZP4RoH8dlNMR75k2BXYJejZlSEr8AawG9aZclj30pytxNyX HDmW3WJm/WGJVIGV/m207V+hQABjsjTYF5GK/wQxjbvOkl1lsqFQCZP3Zs5m6MCHP1kS hAdHJrzqpFhWTDW2SwyHXd65LXiJuaWMSu0BeVHfvjaF4we1m7kvj62NveaxLEmrLAaK o1gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=juyeit0s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y2si43531780pgl.148.2018.11.21.04.20.32; Wed, 21 Nov 2018 04:20:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=juyeit0s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730162AbeKUWxX (ORCPT + 99 others); Wed, 21 Nov 2018 17:53:23 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:52844 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728428AbeKUWxX (ORCPT ); Wed, 21 Nov 2018 17:53:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GWr93rI5vOjJXu1utLg01PpRQmImuvJaHVDucwXozd0=; b=juyeit0swniFgBcdVatbZQ3Ah 01H0iRMsUXNkl/7kET1p6FMPx+2uwJClx5F54ER0Q1hbvpf4tTakc0ZoPPq5TX5AEJD9+o5d09hNu LhytakDVWPnDYVGB6Z9uVyxp6UKTdrcJ7C3QYp+s2nwPTcLjLC6EW+O9Q0gfGS6kk14ZU=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gPRTH-0003OT-Dn; Wed, 21 Nov 2018 12:19:07 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 2890611250AD; Wed, 21 Nov 2018 12:19:07 +0000 (GMT) Date: Wed, 21 Nov 2018 12:19:07 +0000 From: Mark Brown To: Marek Szyprowski Cc: Charles Keepax , linus.walleij@linaro.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH] regulator: wm8994: Don't use devres for enable GPIOs Message-ID: <20181121121907.GB8059@sirena.org.uk> References: <20181120170152.24652-1-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PmA2V3Z32TCmWXqI" Content-Disposition: inline In-Reply-To: X-Cookie: There was a phone call for you. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 21, 2018 at 10:26:30AM +0100, Marek Szyprowski wrote: > from wm8994_ldo_remove(), switched to regulator_register() in > wm8994_ldo_probe() and added regulator_unregister() in > wm8994_ldo_remove(). This way the warning is gone. If there is any I don't understand why you'd need to switch to regulator_register()? --PmA2V3Z32TCmWXqI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlv1TToACgkQJNaLcl1U h9C3fgf8C1bb6yGkcttdeXdyvwZEEn6gl0GMOvwtCHrHWs5iBNArWTUxnbL991iC 8t3nRBVhP9TyKelPK7h0zYAA7hxa3xhfDJRiEVKSjVSEJCzUoCjWetWElAzb8qv2 x7xBm7iAdi3lOsyV9H67ucWKhSaHdp1l7QfTa5PSinQBmfW40MMlq2iPSTI/lUjQ 7cOiOVnCg2UVj5q9WX6KEUgf/uUcbi86V+QQFHObU0cLDulcJGlUEsv2Vs5fBbPz FZHYfyPrIw7mbEPG8SeP9UUzI6FTWa6Ezg60xmi8Kdhnv0px5hZdrutugQ6dQq8G BBRtUQkrZQ0q6bjsa/jRo/Gxhahoow== =lEJM -----END PGP SIGNATURE----- --PmA2V3Z32TCmWXqI--