Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] regulator: wm8994: Don't use devres for enable GPIOs
To:     Mark Brown <broonie@kernel.org>
Cc:     Charles Keepax <ckeepax@opensource.cirrus.com>,
        linus.walleij@linaro.org, lgirdwood@gmail.com,
        linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
From:   Marek Szyprowski <m.szyprowski@samsung.com>
Message-ID: <d9aebaa5-93d0-6b3d-c3b2-f7ef1dbbc4de@samsung.com>
Date:   Wed, 21 Nov 2018 13:24:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
        Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <20181121121907.GB8059@sirena.org.uk>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20181120170248epcas1p2a93ec9ff7f74ad4908166590ed548386@epcas1p2.samsung.com>
        <20181120170152.24652-1-ckeepax@opensource.cirrus.com>
        <c426f174-dc45-3a25-4c7e-018972c2ceef@samsung.com>
        <b7648606-b5d1-c42f-cf68-338fbc3cf4df@samsung.com>
        <20181121121907.GB8059@sirena.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Mark,

On 2018-11-21 13:19, Mark Brown wrote:
> On Wed, Nov 21, 2018 at 10:26:30AM +0100, Marek Szyprowski wrote:
>
>> from wm8994_ldo_remove(), switched to regulator_register() in
>> wm8994_ldo_probe() and added regulator_unregister() in
>> wm8994_ldo_remove(). This way the warning is gone. If there is any
> I don't understand why you'd need to switch to regulator_register()?

I mixed a few things. This was just a first version of my experiments,
which worked without the warning. In the final solution it was not
needed, see https://lkml.org/lkml/2018/11/21/542

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland