Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1981883imu; Wed, 21 Nov 2018 05:06:56 -0800 (PST) X-Google-Smtp-Source: AFSGD/Xr8tssDXsdHoNMNnBs89Ni+1UOTbNQ/89q4eylklpTrLezwb4unsrKFXXuSYCh9/FE+SZM X-Received: by 2002:a17:902:e012:: with SMTP id ca18mr6743345plb.218.1542805616591; Wed, 21 Nov 2018 05:06:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542805616; cv=none; d=google.com; s=arc-20160816; b=slaElctSTylBR9MC4+vpL+WVgtJNDoO5Z5v8pISewi8cV6+OnHkgmkpL0UrTCYVUZ4 MSNDmk11O93e5p2R1T4u5iHboUku6QT4cnKBuFSu+9v/OZfc3vddb7jF9DTydUg+5Med JHB2vOZgS0i/kbgA3RPPew+yyB49PWISoLJfOfnaFnKQavEHoBTMIKi8dZXM5pv1c/Nq w6DcN3PoDd+TZePsQffSAUrmV09OcADlG3CsOQ/mBtJ2BqYsqi9HycMmOtJmEDy9TzGz azf+Q4kcPvta/SPCQARUxVs3kyApsccvTOQ3JHPkr0JBerOdRzUU8L2ZKLWe7CZcmjx3 C1Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=JWLTdLnjGxFNIGXafVQP36uofwcE+NOk64U/yUqhW+c=; b=k9/7tMxwd0JxpC12InBLeNsyvq7PspsTJtVvSMJsEykfFYsSPm330n44NfX09J/rtR gbjnQDqAzgxsybPEeZoFLhzVTDqoTgdAaAevAHsYgmQvO7A6b4kQ5YRhMZrx4aXzUOZP Di2QX9L/be3R1txAseVR2r0Oll4v/DtbnXe2+a0/tvwNS9/rJoUjTFFJAxTSaFzeRtwn uO5NFgJqToq3aTxKqdLXSiZSFk3pOc3MsEM/X3q2sl8CnUqpO7YhNh8PMMvhsSyiRof/ PNvrtmay39TEt0Y62qwFoaV5aoVujH0zRPUgN7LKMS6fVmkJFYexO+s8RYJqsUEZz+ih nWjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@owltronix-com.20150623.gappssmtp.com header.s=20150623 header.b=xxFc2Rdc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3si44981082pgm.441.2018.11.21.05.06.27; Wed, 21 Nov 2018 05:06:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@owltronix-com.20150623.gappssmtp.com header.s=20150623 header.b=xxFc2Rdc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729369AbeKUWJf (ORCPT + 99 others); Wed, 21 Nov 2018 17:09:35 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:37910 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbeKUWJf (ORCPT ); Wed, 21 Nov 2018 17:09:35 -0500 Received: by mail-ua1-f68.google.com with SMTP id p9so1790385uaa.5 for ; Wed, 21 Nov 2018 03:35:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owltronix-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JWLTdLnjGxFNIGXafVQP36uofwcE+NOk64U/yUqhW+c=; b=xxFc2RdcVcm+lLxm0vbzvk6kzc1oeWuigVB7YfrUlhdA/WXZuEcbLEii1HUA+3C7Y7 JununLQ/wW7Wh3RdII0QgvFyI9Fvqdh7dLAixMYNGw3m7zYQAvcdJD/yRxNv3lWqtyht qLoIQN87y1x6yypRffvpl0z9V19PiXxDCpswCG+PYymDZoxfmhdcC++IvDEZ+ndECYcl 4Rq5eA2gW0cxluUoB0YRRW68+w2Zs5U1HyH3nhJVlnoA6g63UIxDA9TKD4KLpI3wE2hP zScM2Tw+ifFyPmED0AytR23vzLIFXgOGelmxdC8TjkeJqc0fJ+CJaVzPl5oaNRCcIYxP aWfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JWLTdLnjGxFNIGXafVQP36uofwcE+NOk64U/yUqhW+c=; b=ReYFvyrksgzeX9+epZXNsJ8aI0obz6FJciNBqweB0IRwU+hIT6alqV8Ig7Im/ND1uW cuDeABVVtoE0pGNWtKtkke8Ud6WcbP2/Hi1p/7toyZHUCwrfDRHYwx4WDNt5HA9KtYel fjyP5cczaJmKu2MJPmdQHY9U0H/a7BeoGaBhxg2gUQ2P+2iJBeyOKfQ/76dNaQ1bGN7k h8c2/3HJ47AM7FCqlcFtK+zrZrP5POATc+CQRnBLVEROXGGTkk0VpN8PhnPlZ30DT7/x VtzmI2f3yNg87x/ApThrliHOBIR8nRJ9KN4Hkx5cRp/X7exQV93xa6+ccfPXGxZRgrF8 mo/g== X-Gm-Message-State: AA+aEWbjXL3mcbgwHKjCHcdIwYG/JsuBfYvzrZPJGgCih1HRYXjbc7Li uFdWjmidQPz50xgcXSv6Wm3O7enpjvZBWkW4GTZULg== X-Received: by 2002:ab0:49ee:: with SMTP id f43mr2523985uad.29.1542800130866; Wed, 21 Nov 2018 03:35:30 -0800 (PST) MIME-Version: 1.0 References: <20181121095423.20760-1-hans.ml.holmberg@owltronix.com> <154279503602.15074.8041259573781223214@jlahtine-desk.ger.corp.intel.com> In-Reply-To: <154279503602.15074.8041259573781223214@jlahtine-desk.ger.corp.intel.com> From: Hans Holmberg Date: Wed, 21 Nov 2018 12:35:19 +0100 Message-ID: Subject: Re: [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates To: Joonas Lahtinen Cc: David Airlie , Jani Nikula , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List , Hans Holmberg Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 21, 2018 at 11:10 AM Joonas Lahtinen wrote: > > Quoting Hans Holmberg (2018-11-21 11:54:23) > > From: Hans Holmberg > > > > There is no need to rebuild i915_gpu_error.o when the version string > > changes as the version is available in init_utsname()->release. > > > > Signed-off-by: Hans Holmberg > > Seems reasonable to me. > > Reviewed-by: Joonas Lahtinen > > Out of curiosity, are you by any chance hashing the i915_gpu_error.o > file (or the contents elsewhere) for some purpose? Oh no, I was just moderately annoyed by the file being rebuilt every time the version was updated(I use my current branch name as LOCALVERSION when building). Thanks, Hans > > Regards, Joonas > > > --- > > drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > > index 8762d17b6659..958e1484a3dd 100644 > > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > > @@ -27,7 +27,7 @@ > > * > > */ > > > > -#include > > +#include > > #include > > #include > > #include > > @@ -650,7 +650,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m, > > > > if (*error->error_msg) > > err_printf(m, "%s\n", error->error_msg); > > - err_printf(m, "Kernel: " UTS_RELEASE "\n"); > > + err_printf(m, "Kernel: %s\n", init_utsname()->release); > > ts = ktime_to_timespec64(error->time); > > err_printf(m, "Time: %lld s %ld us\n", > > (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC); > > -- > > 2.17.1 > >