Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2011801imu; Wed, 21 Nov 2018 05:31:56 -0800 (PST) X-Google-Smtp-Source: AJdET5eKu4MsHp4+391VXHNUIgke9XUptV99iPACpcopG/X+sKgxs5pVqj+CqlbKp/7q+3tV/YcA X-Received: by 2002:a62:13c3:: with SMTP id 64mr6791103pft.93.1542807116652; Wed, 21 Nov 2018 05:31:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542807116; cv=none; d=google.com; s=arc-20160816; b=EQP1gOcEnoTRT/NiHQFKnjzFY7fatq4VnMxFBede5Roc3tywCb++aE+CYWX2yzBfR6 Tfai5OEJ3U+eYwX4t+C439BraLybB3J0+gaPR25dDt+q6pXJsER2NJee/Givn+b4dVgT a+JWvds7NTiwJeG72lWEYbfwupzoQyn7kj6W3nQEuYwJGxCOHiGaFFRH1SbacFZznnYS BBuPyQVSp4l0zi2phBoxUgYk3GoKzAUr+rnxay/3VX/VcYlxt4PCeND3jZ8I3OjgaqAk /UCHkOIqveJEB4YXS9Y/M9IPNRFZkLJjVYNOK8C+uH7oj7/iEuwbHFssA122vGKA3GwA vBUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=XpADW7oy/CtsN60pSotwU7P9NnmgHpwGnq+aATSuM2k=; b=OvjK/2Dq34i4vAWde+lJcqkMKhauf33C0mXyMuLKJ8PkPWrhejqJGAcnRnHf1G+avu DIwAqCUM2xwC1iByp7HZDpdy8HBkluUJIzS+462s2mneVC7ySfZCkCuc0bXK495YaQGc 4fH6SfGt1VOeQwKz363zbvzq787jaVxFzACgq/2xc1IT74V/if6/F7TbaxXr8uQxr7Kh xlkZ8GdGH+OzXO2X/LEugPshGrBmOdNY83FblIDuzBjCMlD5X9GoSVdT9nP5xRIRdGnZ AaO7cfrL89cfPZFBF1sEd1leb0vOkdFHj/hYGpbjqNNcjnXNhqL9BXk0eknzxbboyI7s oQIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DQ9lC7ex; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l14si43741636pgi.147.2018.11.21.05.31.30; Wed, 21 Nov 2018 05:31:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DQ9lC7ex; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730765AbeKUXjC (ORCPT + 99 others); Wed, 21 Nov 2018 18:39:02 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:33724 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727046AbeKUXjB (ORCPT ); Wed, 21 Nov 2018 18:39:01 -0500 Received: by mail-pl1-f193.google.com with SMTP id z23so5494603plo.0; Wed, 21 Nov 2018 05:04:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XpADW7oy/CtsN60pSotwU7P9NnmgHpwGnq+aATSuM2k=; b=DQ9lC7exOmLcrAAlRa5xNuMTb0TpnSyL3ygTB5TKlVtqXrboFn+HZzfUz6fndRiIUp Fy/JB/2/6RNusM2ZIp0q9l6QzLjD91cdUnJkQ8B1alkkypnlZUhtUTg4QZf/BO4LgTu0 8ta5BrPY/gvl+vvcpXllxynLQvgbe0WwL/SsxSr+9EYmMLyZ0EzyJqfueajGRANB2Kvo 5DZicNqYSENPkV/EhIdMM15IfL4rH3TQSyvMy+H40LwJ6zqAvxJXi8dRfQcFIgOReK4g uMQpqfz35nBT5IJXjFDGSsBAID6zJovd5ylTzJ5Zqw/EC+MqwpUFBx53gB8qSwY9snSt iE2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XpADW7oy/CtsN60pSotwU7P9NnmgHpwGnq+aATSuM2k=; b=a3BPssOe8mHc931gcI55upRusjqIFxvzXELkgN/wz3iWy9+D5vcj6FZMe3MeBfaDC3 qwsQJyWkY3wPonmUgUlKv93YpOZQ9qqdR5ozo2fYW8DUHIw/ttE4RUrzKKW0hoUk1Y+5 qcsAVu9NJ/SbHJqnvuH25VgLnNEanxNom0CpljvSdQ/Tk5yq3nPwazNZ976N1pM1Zq1s 8pj017dWNdsVLgsLa9CjMeY9HPZDzA8esMoivQd4SKVeYnqFg5nAMC6OkjABy80I17hB FzUXatvff6ou5TIQ3+mhcAyL5MEh1t79Sm+QrfNp0IAgxxpSozUr8sg9iTotU1/WpNZt LJqQ== X-Gm-Message-State: AA+aEWaCgW8+H4l5crfKCGOvIzzNIyH8fYOhwB4rK6jyHDuikOh4vXju lhSm7+m5awMitU4DMDZ/70/H9gP+JC8= X-Received: by 2002:a17:902:76c2:: with SMTP id j2mr6787812plt.339.1542805483610; Wed, 21 Nov 2018 05:04:43 -0800 (PST) Received: from localhost (68.168.130.77.16clouds.com. [68.168.130.77]) by smtp.gmail.com with ESMTPSA id h8sm22857863pfo.162.2018.11.21.05.04.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Nov 2018 05:04:42 -0800 (PST) From: Yangtao Li To: b.zolnierkie@samsung.com, axboe@kernel.dk Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Yangtao Li Subject: [PATCH] ata: pata_macio: add of_node_put() Date: Wed, 21 Nov 2018 08:04:39 -0500 Message-Id: <20181121130439.22255-1-tiny.windzz@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. Signed-off-by: Yangtao Li --- drivers/ata/pata_macio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c index 9588e685d994..8cc9c429ad95 100644 --- a/drivers/ata/pata_macio.c +++ b/drivers/ata/pata_macio.c @@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap) struct device_node *root = of_find_node_by_path("/"); const char *model = of_get_property(root, "model", NULL); + of_node_put(root); + if (cable && !strncmp(cable, "80-", 3)) { /* Some drives fail to detect 80c cable in PowerBook * These machine use proprietary short IDE cable -- 2.17.0