Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2104685imu; Wed, 21 Nov 2018 06:48:15 -0800 (PST) X-Google-Smtp-Source: AJdET5fnJkThYyTT6E8t81Bgx9diVvkw2+ZE3YtxWUga4FQSWMu9UsQ/uqYSN7Zt+dN6aNmHubC5 X-Received: by 2002:a62:4549:: with SMTP id s70mr7001399pfa.233.1542811695715; Wed, 21 Nov 2018 06:48:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542811695; cv=none; d=google.com; s=arc-20160816; b=XT+O53tROXePsZ8KIUx+DSrjdTcBtzo0o5rK+Gg2cf25Jrpmzeu0dXkPuVzXdPU5d0 ElMJBa/iS60GU/92e24d3tc9HYaQ9/fJtnvqM5mnAPTDTkY33iIE0c1CkuaTcUGWbpy+ xTQzuZMVfcVaZYk1hZWrei3QYQlwYbrsoqKM56EBiPS/dXL5ITtC3toH3Bz6QYX98g9n OyXjWMhMiy9CP2mcK0tsPnfU67U80eOjlf9w3w/RRlidPEHNEti4FMM2HOJOjazbOIAw eW7Objv157/riILkSZGMt0TxrmnGdaFNFIcEBxcG39dDiWK1+99zpnud9vnqxEC/mI7X B+XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=xy7MccKEKYg95kZohZdiR5wZbdk+kdGHER5W08Ahjyo=; b=tJCUcl6XxwclMAna/3BfOjL1GlTZ6fd9SJl2NUNq11p/9l4TuJMkHeVbT/sDngejoC nhDFK8nA7fk1Q3k9wr6Qs8R/Aj0YMJpS9+OxprIR+ITM/xRdccRgt128Z3dlnwRsB1am vyP6hbetEmWgWDq4xLrWq77QTJKqwwV1EpphQEueLOmmhFAxlYnIT3ZSHvIdVajrKuPo 8feOdJ804AJ/dG0R1FuDwxbVlE4a76xgo9ATfEbvJ6aMyOneFI3RsKAiXl7aVfbBmtOA tCxUfFf8tdMjUcQEb7Lft+XxLm+cFeeipklgUzQGhXRD7V6h9Hb3Pz8oBWdRdEoB3ciC Odpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=Wjzk0UsN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g17si18998850pgi.578.2018.11.21.06.47.49; Wed, 21 Nov 2018 06:48:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=Wjzk0UsN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730173AbeKVBGU (ORCPT + 99 others); Wed, 21 Nov 2018 20:06:20 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:44406 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728283AbeKVBGU (ORCPT ); Wed, 21 Nov 2018 20:06:20 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wALEEWWl073172; Wed, 21 Nov 2018 14:29:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2018-07-02; bh=xy7MccKEKYg95kZohZdiR5wZbdk+kdGHER5W08Ahjyo=; b=Wjzk0UsN6BBqHy6tkEukt8nv9s4YXXHv+7rOwjkA6frDw0BZkl5IdaLTGd2nXpBxXoab 4XKjZWO6PXOmB69z+hwoc4SEIYq/fTUWOLuduAMXn8SK2O8MVYqDoUZMfFa/J3K+TOFg Ys0BZMNPQp+y4M69qSwl/srpzcWqDyEjk5iJHKK9SyJHnBAC3yps+cfM4x6myDc+HbFB FCUNLDCXon8N1iOC00hdncX4zbSRiS/Mn444IqRI14X7fhzbHJ4M71i9Ag3jHR633Z10 MpZi7NipZunChCjIeIWuB0Gq16abZggbMJFG1YWlzVvx/I6hhEPoEGKHc001POwVgNUQ Bg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2ntadu1uyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Nov 2018 14:29:50 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wALETnn3003104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Nov 2018 14:29:49 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wALETeA7027352; Wed, 21 Nov 2018 14:29:40 GMT Received: from [192.168.0.110] (/73.243.10.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 21 Nov 2018 06:29:39 -0800 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [PATCH 1/9] mm: Introduce new vm_insert_range API From: William Kucharski In-Reply-To: <20181121123513.GF3065@bombadil.infradead.org> Date: Wed, 21 Nov 2018 07:29:37 -0700 Cc: Souptick Joarder , rppt@linux.ibm.com, Andrew Morton , Michal Hocko , "Kirill A. Shutemov" , vbabka@suse.cz, Rik van Riel , Stephen Rothwell , rppt@linux.vnet.ibm.com, Peter Zijlstra , Russell King - ARM Linux , robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com, Kees Cook , Marek Szyprowski , stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, Heiko Stuebner , airlied@linux.ie, oleksandr_andrushchenko@epam.com, joro@8bytes.org, pawel@osciak.com, Kyungmin Park , mchehab@kernel.org, Boris Ostrovsky , Juergen Gross , linux-kernel@vger.kernel.org, Linux-MM , linux-arm-kernel@lists.infradead.org, linux1394-devel@lists.sourceforge.net, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xen.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20181115154530.GA27872@jordon-HP-15-Notebook-PC> <20181116182836.GB17088@rapoport-lnx> <20181117143742.GB7861@bombadil.infradead.org> <833B5050-DEF6-44A0-9832-276F86671212@oracle.com> <20181121123513.GF3065@bombadil.infradead.org> To: Matthew Wilcox X-Mailer: Apple Mail (2.3445.102.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9083 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=618 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811210126 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Nov 21, 2018, at 5:35 AM, Matthew Wilcox = wrote: >=20 > It's probably better to be more explicit and answer Randy's question: >=20 > * If we fail to insert any page into the vma, the function will return > * immediately leaving any previously-inserted pages present. Callers > * from the mmap handler may immediately return the error as their > * caller will destroy the vma, removing any successfully-inserted = pages. > * Other callers should make their own arrangements for calling = unmap_region(). That works for me as well.