Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181121130439.22255-1-tiny.windzz@gmail.com> <e45f832b-ef98-e419-6082-27dd7ced71d2@cogentembedded.com>
In-Reply-To: <e45f832b-ef98-e419-6082-27dd7ced71d2@cogentembedded.com>
From:   Frank Lee <tiny.windzz@gmail.com>
Date:   Wed, 21 Nov 2018 23:31:24 +0800
Message-ID: <CAEExFWvw1tw-AWbp1beajZNCRLYQXdiC6ifMvGc5_po64i_GtQ@mail.gmail.com>
Subject: Re: [PATCH] ata: pata_macio: add of_node_put()
To:     sergei.shtylyov@cogentembedded.com
Cc:     b.zolnierkie@samsung.com, axboe@kernel.dk,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 21, 2018 at 11:24 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>
> Hello!
>
> On 11/21/2018 04:04 PM, Yangtao Li wrote:
>
> > of_find_node_by_path() acquires a reference to the node
> > returned by it and that reference needs to be dropped by its caller.
> > bl_idle_init() doesn't do that, so fix it.
>
>    I thought we're inside pata_macio_cable_detect()?
Hi Sergei=EF=BC=9A

What do you mean?
Why not release the refcount of root?

Yours,
    Yangtao
>
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> >  drivers/ata/pata_macio.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> > index 9588e685d994..8cc9c429ad95 100644
> > --- a/drivers/ata/pata_macio.c
> > +++ b/drivers/ata/pata_macio.c
> > @@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port =
*ap)
> >               struct device_node *root =3D of_find_node_by_path("/");
> >               const char *model =3D of_get_property(root, "model", NULL=
);
> >
> > +             of_node_put(root);
> > +
> >               if (cable && !strncmp(cable, "80-", 3)) {
> >                       /* Some drives fail to detect 80c cable in PowerB=
ook
> >                        * These machine use proprietary short IDE cable
>
> MBR, Sergei