Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2246681imu; Wed, 21 Nov 2018 08:43:30 -0800 (PST) X-Google-Smtp-Source: AFSGD/VynY1cbpOkuJ7O9FUdV2oT8n1CD+mZjkCuwilb1wYG66zW49cjpwsGV0IGlxM7FMAzpHvB X-Received: by 2002:a17:902:64:: with SMTP id 91-v6mr7605594pla.161.1542818610160; Wed, 21 Nov 2018 08:43:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542818610; cv=none; d=google.com; s=arc-20160816; b=Bg/tUzoLaRwIRvKLdcHb94SjZkaWWw3vbYFGc998/LM/V7g1GcCkjqCny8pJx4wbgl I1NmTm2n23p5LyWnK9oTPyiVJKMjQ5/wWGUPluFexvAOgvZv6vBZu2GeDCUDu2HSlpFI 5FtMOzLTZd/psRHkvsNYNqU2ZFtyd2T5GwDimxPemUwYaVn4T0J/QDbXU+ty7jTAOY06 FudoTVFF6PYyACM5tTxOlElgK9gWn4rzCQ5BxHgYfUOb9xfsAEQY33lkb/zH2w7joJGL OzX3Kbx5rIan/ZKHQl9HD7KSFa95UTThbHGPxyyNHVwbtXA/q8dRkaeyvENuk5KaPJEZ uC2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=tju3b7q5zI8/VqHsmhHjvOGbTGeoYxy6iR6gOnwPnAk=; b=RuPQWyYY2e+uOZ1lgW5OqMdqEdvpapYQi+V6Cq4kSmf7Gp0ib1kGk4sreMR6iKznuA TjciXXGg8Ek6eFDNEvPSdtKgd0b1gfzvREtQ9/t37quBwG3E3RRZJ0xLLhwltuSwqoUB 9xA6U6LVQZ3knrfcap3CN2tez+xEEve4qtX4kwmoFrFLbIN+eb1nKDohEHcY8JSYtyYG ibRCUwbmxUJfE0bJk4VEB3RGvCYp7Hw4toug8/FHbUKh2ODrpcH0Oz4vI5m11x8DFRdY ri38UqzWQXE8Tef4hiI7kwmXAyXYd6SUPDfwRpPOmjuqdY76Z4ouxShzk14H1JkcLJK8 bXqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w61si9332939plb.309.2018.11.21.08.43.14; Wed, 21 Nov 2018 08:43:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730814AbeKVAfB (ORCPT + 99 others); Wed, 21 Nov 2018 19:35:01 -0500 Received: from verein.lst.de ([213.95.11.211]:51531 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728520AbeKVAfB (ORCPT ); Wed, 21 Nov 2018 19:35:01 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 3919568C19; Wed, 21 Nov 2018 15:00:27 +0100 (CET) Date: Wed, 21 Nov 2018 15:00:27 +0100 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V11 10/19] block: loop: pass multi-page bvec to iov_iter Message-ID: <20181121140027.GA2323@lst.de> References: <20181121032327.8434-1-ming.lei@redhat.com> <20181121032327.8434-11-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181121032327.8434-11-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 1ad6eafc43f2..a281b6737b61 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -805,6 +805,10 @@ struct req_iterator { > __rq_for_each_bio(_iter.bio, _rq) \ > bio_for_each_segment(bvl, _iter.bio, _iter.iter) > > +#define rq_for_each_bvec(bvl, _rq, _iter) \ > + __rq_for_each_bio(_iter.bio, _rq) \ > + bio_for_each_bvec(bvl, _iter.bio, _iter.iter) > + I think this should go into the patch adding bio_for_each_bvec and friends. Otherwise looks fine: Reviewed-by: Christoph Hellwig