Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181121124912.22074-1-tiny.windzz@gmail.com> <f38e8b29-d1db-f915-6699-aec9013bfe7e@nvidia.com>
 <0299646d-3f54-09fc-fea1-ddc9fbe5c8cc@nvidia.com>
In-Reply-To: <0299646d-3f54-09fc-fea1-ddc9fbe5c8cc@nvidia.com>
From:   Frank Lee <tiny.windzz@gmail.com>
Date:   Wed, 21 Nov 2018 22:44:26 +0800
Message-ID: <CAEExFWsUhrjwwb1O3xgL-T-2Jd8Bt0HMWeTovHRZ_=TLX15Ssw@mail.gmail.com>
Subject: Re: [PATCH] soc/tegra: add of_node_put()
To:     jonathanh@nvidia.com
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 21, 2018 at 10:41 PM Jon Hunter <jonathanh@nvidia.com> wrote:
>
>
> On 21/11/2018 13:31, Jon Hunter wrote:
> >
> > On 21/11/2018 12:49, Yangtao Li wrote:
> >> of_find_node_by_path() acquires a reference to the node
> >> returned by it and that reference needs to be dropped by its caller.
> >> bl_idle_init() doesn't do that, so fix it.
>
> The bl_idle_init() looks like a typo here.
Hi Jon:

Thanks. :-)

Yous,
    Yangtao
>
> >>
> >> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> >> ---
> >>  drivers/soc/tegra/common.c | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c
> >> index cd8f41351add..2e30604c9658 100644
> >> --- a/drivers/soc/tegra/common.c
> >> +++ b/drivers/soc/tegra/common.c
> >> @@ -23,10 +23,13 @@ static const struct of_device_id tegra_machine_match[] = {
> >>  bool soc_is_tegra(void)
> >>  {
> >>      struct device_node *root;
> >> +    bool rc;
> >>
> >>      root = of_find_node_by_path("/");
> >>      if (!root)
> >>              return false;
> >>
> >> -    return of_match_node(tegra_machine_match, root) != NULL;
> >> +    rc = of_match_node(tegra_machine_match, root) != NULL;
> >> +    of_node_put(root);
> >> +    return rc;
> >>  }
> >
> > Thanks for the fix, however, I think it would be even simpler just to
> > call of_machine_is_compatible() here instead.
>
> Right so I was wrong above about using of_machine_is_compatible, so with
> the typo above fixed ...
>
> Acked-by: Jon Hunter <jonathanh@nvidia.com>
>
> Cheers
> Jon
>
> --
> nvpublic