Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2406425imu; Wed, 21 Nov 2018 11:07:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/VL+Yo1QRJQJ1qzMX4jZp85iOBnLueO16eF7nAz68qQQWn4ptmQ7d5GsXCRKY+e5M4rr14W X-Received: by 2002:a17:902:bc83:: with SMTP id bb3-v6mr7859885plb.223.1542827254603; Wed, 21 Nov 2018 11:07:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542827254; cv=none; d=google.com; s=arc-20160816; b=LkSbsVE667fluHWxIuMKtNsOOGo5OgCxyQtFPA18V5NthXfNNM5j8TEVuQpkS4WC64 nlh4q+dYrUP7lEpMvXA2pYpWlU54PDaPRZmacITKxLQNZ3S/gJ98CAuqQpKIYUuMNKDE mgCY94GfmW600S74/yrKweWb29+kpGA08hq93IAH8rbn+Gvx6KLPUzfcgWsFvMq4L1rt vAn9eGEW1JrlA+pIpycRfOGqXhCHZtFR0xfAZZN20gByfn9qWT1V8OK0SV2fRazKWhNs qAT2pe+dgyphEALrSK+hDZ3cCJeZB27dgLzKWObtcd/uvGXajZPxJjMV3ZAgJ2g1NSEJ 5Sog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=oE7on3VvtdkIbMDlGvH9/HrY+IIAJ4cP3zV/jfnrvuc=; b=pinZX7AigbqjlWQf4/jSWaixyHZXSMWOAmoIJLj+FnVUeZGn2MZzYRKGF7URnKpsaz gATusJl0ERLSUTHjQx54RnFmkyTdn/iRjpy7oyXYGyMnxrSsPHg1kOsHJrSLReAm3uJZ hDS/edkv9U7d5gjTrVvPGgiR6H+uxnVpWpLOCVmiliZf+3w6F/yBaFmoFWnjZNQyJk8v v0FGig+nI6iUxcQzqGAvcSbbjmecjsNma74aFIcD1BRcrzp5nNVrNNKrzqTl17YQ9ZZ7 ZGiyh4k+lWJnQYP+fD7ZAmJhCMlmHWH6lDq2jT5eWaB5slr1NooLHGvlZKdr1IL7ky8A WBgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l123-v6si50285762pfl.200.2018.11.21.11.07.15; Wed, 21 Nov 2018 11:07:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729854AbeKVDSM (ORCPT + 99 others); Wed, 21 Nov 2018 22:18:12 -0500 Received: from www.osadl.org ([62.245.132.105]:41898 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727100AbeKVDSM (ORCPT ); Wed, 21 Nov 2018 22:18:12 -0500 Received: from debian01.hofrr.at (178.115.242.59.static.drei.at [178.115.242.59]) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id wALGccSH001213; Wed, 21 Nov 2018 17:38:38 +0100 From: Nicholas Mc Guire To: Linus Walleij Cc: Bartosz Golaszewski , Matthias Brugger , Sergio Paracuellos , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Nicholas Mc Guire Subject: [PATCH] gpio: mt7621: handle failure of devm_kasprintf() Date: Wed, 21 Nov 2018 17:35:42 +0100 Message-Id: <1542818142-27800-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 X-Spam-Status: No, score=-4.2 required=6.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on www.osadl.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kasprintf() may return NULL on failure of internal allocation thus the assigned label is not safe if not explicitly checked. On error mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the (unlikely) failure case should be fine here. Signed-off-by: Nicholas Mc Guire Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") --- Problem located with experimental coccinelle script Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y, GPIOLIB=y, GPIO_MT7621=y Patch is against 4.20-rc3 (localversion-next is next-20181121) drivers/gpio/gpio-mt7621.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c index d72af6f..42f0c67 100644 --- a/drivers/gpio/gpio-mt7621.c +++ b/drivers/gpio/gpio-mt7621.c @@ -244,6 +244,10 @@ mediatek_gpio_bank_probe(struct device *dev, rg->chip.of_xlate = mediatek_gpio_xlate; rg->chip.label = devm_kasprintf(dev, GFP_KERNEL, "%s-bank%d", dev_name(dev), bank); + if (!rg->chip.label) { + dev_err(dev, "Could not allocate label\n"); + return -ENOMEM; + } ret = devm_gpiochip_add_data(dev, &rg->chip, mtk); if (ret < 0) { -- 2.1.4