Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vineet Gupta <vineet.gupta1@synopsys.com>
To:     Alexey Brodkin <alexey.brodkin@synopsys.com>,
        "linux-snps-arc@lists.infradead.org" 
        <linux-snps-arc@lists.infradead.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Cupertino Miranda" <cupertino.miranda@synopsys.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] arc: [devboards] Add support of NFSv3 ACL
Thread-Topic: [PATCH] arc: [devboards] Add support of NFSv3 ACL
Thread-Index: AQHUgLwOF1eu85U5oUezfol+m7ZGcA==
Date:   Wed, 21 Nov 2018 17:40:17 +0000
Message-ID: <C2D7FE5348E1B147BCA15975FBA2307501464156CB@US01WEMBX2.internal.synopsys.com>
References: <20181120103019.12852-1-abrodkin@synopsys.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/20/18 2:30 AM, Alexey Brodkin wrote:=0A=
> By default NFSv3 doesn't support ACL (Access Control Lists)=0A=
> which might be quite convenient to have so that=0A=
> mounted NFS behaves exactly as any other local file-system.=0A=
>=0A=
> In particular missing support of ACL makes umask useless.=0A=
> This among other thigs fixes Glibc's "nptl/tst-umask1".=0A=
>=0A=
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>=0A=
> Cc: Cupertino Miranda <cmiranda@synopsys.com>=0A=
> Cc: stable@vger.kernel.org=0A=
=0A=
What is this fixing in the kernel, for this to be stable backported  ?=0A=
=0A=
> ---=0A=
>  arch/arc/configs/axs101_defconfig          | 1 +=0A=
>  arch/arc/configs/axs103_defconfig          | 1 +=0A=
>  arch/arc/configs/axs103_smp_defconfig      | 1 +=0A=
>  arch/arc/configs/hsdk_defconfig            | 1 +=0A=
>  arch/arc/configs/nps_defconfig             | 1 +=0A=
>  arch/arc/configs/nsimosci_defconfig        | 1 +=0A=
>  arch/arc/configs/nsimosci_hs_defconfig     | 1 +=0A=
>  arch/arc/configs/nsimosci_hs_smp_defconfig | 1 +=0A=
>  arch/arc/configs/vdk_hs38_defconfig        | 1 +=0A=
>  arch/arc/configs/vdk_hs38_smp_defconfig    | 1 +=0A=
=0A=
I understand a sweeping change is easy, more consistent so a good guiding=
=0A=
principel in general. But really all these defconfigs need NFS ? We keep on=
=0A=
increasing the bloat with this. IMHO we should update only relevant defconf=
igs.=0A=
=0A=
>  10 files changed, 10 insertions(+)=0A=
>=0A=
> diff --git a/arch/arc/configs/axs101_defconfig b/arch/arc/configs/axs101_=
defconfig=0A=
> index 41bc08be6a3b..8c23bd086cd0 100644=0A=
> --- a/arch/arc/configs/axs101_defconfig=0A=
> +++ b/arch/arc/configs/axs101_defconfig=0A=
> @@ -95,6 +95,7 @@ CONFIG_VFAT_FS=3Dy=0A=
>  CONFIG_NTFS_FS=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  CONFIG_NLS_CODEPAGE_437=3Dy=0A=
>  CONFIG_NLS_ISO8859_1=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
> diff --git a/arch/arc/configs/axs103_defconfig b/arch/arc/configs/axs103_=
defconfig=0A=
> index 1e1c4a8011b5..666314fffc60 100644=0A=
> --- a/arch/arc/configs/axs103_defconfig=0A=
> +++ b/arch/arc/configs/axs103_defconfig=0A=
> @@ -94,6 +94,7 @@ CONFIG_VFAT_FS=3Dy=0A=
>  CONFIG_NTFS_FS=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  CONFIG_NLS_CODEPAGE_437=3Dy=0A=
>  CONFIG_NLS_ISO8859_1=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
> diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs=
103_smp_defconfig=0A=
> index 6b0c0cfd5c30..429832b8560b 100644=0A=
> --- a/arch/arc/configs/axs103_smp_defconfig=0A=
> +++ b/arch/arc/configs/axs103_smp_defconfig=0A=
> @@ -97,6 +97,7 @@ CONFIG_VFAT_FS=3Dy=0A=
>  CONFIG_NTFS_FS=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  CONFIG_NLS_CODEPAGE_437=3Dy=0A=
>  CONFIG_NLS_ISO8859_1=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
> diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defc=
onfig=0A=
> index 1dec2b4bc5e6..2a1d2cbfee1a 100644=0A=
> --- a/arch/arc/configs/hsdk_defconfig=0A=
> +++ b/arch/arc/configs/hsdk_defconfig=0A=
> @@ -65,6 +65,7 @@ CONFIG_EXT3_FS=3Dy=0A=
>  CONFIG_VFAT_FS=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  CONFIG_NLS_CODEPAGE_437=3Dy=0A=
>  CONFIG_NLS_ISO8859_1=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
> diff --git a/arch/arc/configs/nps_defconfig b/arch/arc/configs/nps_defcon=
fig=0A=
> index 31ba224bbfb4..ae7a0d8be98d 100644=0A=
> --- a/arch/arc/configs/nps_defconfig=0A=
> +++ b/arch/arc/configs/nps_defconfig=0A=
> @@ -73,6 +73,7 @@ CONFIG_PROC_KCORE=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  # CONFIG_MISC_FILESYSTEMS is not set=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  CONFIG_ROOT_NFS=3Dy=0A=
>  CONFIG_DEBUG_INFO=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
> diff --git a/arch/arc/configs/nsimosci_defconfig b/arch/arc/configs/nsimo=
sci_defconfig=0A=
> index f14eeff7d308..ad77f20e5aa6 100644=0A=
> --- a/arch/arc/configs/nsimosci_defconfig=0A=
> +++ b/arch/arc/configs/nsimosci_defconfig=0A=
> @@ -66,5 +66,6 @@ CONFIG_EXT2_FS_XATTR=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  # CONFIG_MISC_FILESYSTEMS is not set=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
>  # CONFIG_ENABLE_MUST_CHECK is not set=0A=
> diff --git a/arch/arc/configs/nsimosci_hs_defconfig b/arch/arc/configs/ns=
imosci_hs_defconfig=0A=
> index 025298a48305..1638e5bc9672 100644=0A=
> --- a/arch/arc/configs/nsimosci_hs_defconfig=0A=
> +++ b/arch/arc/configs/nsimosci_hs_defconfig=0A=
> @@ -65,5 +65,6 @@ CONFIG_EXT2_FS_XATTR=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  # CONFIG_MISC_FILESYSTEMS is not set=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
>  # CONFIG_ENABLE_MUST_CHECK is not set=0A=
> diff --git a/arch/arc/configs/nsimosci_hs_smp_defconfig b/arch/arc/config=
s/nsimosci_hs_smp_defconfig=0A=
> index df7b77b13b82..11cfbdb0f441 100644=0A=
> --- a/arch/arc/configs/nsimosci_hs_smp_defconfig=0A=
> +++ b/arch/arc/configs/nsimosci_hs_smp_defconfig=0A=
> @@ -76,6 +76,7 @@ CONFIG_EXT2_FS_XATTR=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  # CONFIG_MISC_FILESYSTEMS is not set=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
>  # CONFIG_ENABLE_MUST_CHECK is not set=0A=
>  CONFIG_FTRACE=3Dy=0A=
> diff --git a/arch/arc/configs/vdk_hs38_defconfig b/arch/arc/configs/vdk_h=
s38_defconfig=0A=
> index db47c3541f15..1e59a2e9c602 100644=0A=
> --- a/arch/arc/configs/vdk_hs38_defconfig=0A=
> +++ b/arch/arc/configs/vdk_hs38_defconfig=0A=
> @@ -85,6 +85,7 @@ CONFIG_NTFS_FS=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  CONFIG_JFFS2_FS=3Dy=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  CONFIG_NLS_CODEPAGE_437=3Dy=0A=
>  CONFIG_NLS_ISO8859_1=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
> diff --git a/arch/arc/configs/vdk_hs38_smp_defconfig b/arch/arc/configs/v=
dk_hs38_smp_defconfig=0A=
> index a8ac5e917d9a..b5c3f6c54b03 100644=0A=
> --- a/arch/arc/configs/vdk_hs38_smp_defconfig=0A=
> +++ b/arch/arc/configs/vdk_hs38_smp_defconfig=0A=
> @@ -90,6 +90,7 @@ CONFIG_NTFS_FS=3Dy=0A=
>  CONFIG_TMPFS=3Dy=0A=
>  CONFIG_JFFS2_FS=3Dy=0A=
>  CONFIG_NFS_FS=3Dy=0A=
> +CONFIG_NFS_V3_ACL=3Dy=0A=
>  CONFIG_NLS_CODEPAGE_437=3Dy=0A=
>  CONFIG_NLS_ISO8859_1=3Dy=0A=
>  # CONFIG_ENABLE_WARN_DEPRECATED is not set=0A=
=0A=