Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Nov 2018 18:33:51 +0100 (CET)
From:   Julia Lawall <julia.lawall@lip6.fr>
To:     Anatolij Gustschin <agust@denx.de>
cc:     linux-usb@vger.kernel.org, linux-spi@vger.kernel.org,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, broonie@kernel.org, atull@kernel.org,
        mdf@kernel.org, kbuild-all@01.org
Subject: [PATCH] usb: misc: fix boolconv.cocci warnings
Message-ID: <alpine.DEB.2.21.1811211832430.2779@hadrien>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: kbuild test robot <fengguang.wu@intel.com>

drivers/usb/misc/ft232h-intf.c:816:27-32: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

Fixes: 0772a5bf580c ("usb: misc: add driver for FT232H based FPGA configuration devices")
CC: Anatolij Gustschin <agust@denx.de>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Signd-off-by: Julia Lawall <julia.lawall@lip6.fr>

---

url:    https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181120-161201
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago

Please take the patch only if it's a positive warning. Thanks!

 ft232h-intf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/misc/ft232h-intf.c
+++ b/drivers/usb/misc/ft232h-intf.c
@@ -813,7 +813,7 @@ static int ftdi_mpsse_gpio_get(struct gp

 	dev_dbg(chip->parent, "%s: offset %d\n", __func__, offset);

-	low = offset < 5 ? true : false;
+	low = offset < 5;

 	mutex_lock(&priv->ops_mutex);