Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2491245imu; Wed, 21 Nov 2018 12:29:35 -0800 (PST) X-Google-Smtp-Source: AFSGD/Utvre0xuSSiZVTTOjwLSwsAoBelDsFHVdU0XFqJP3nQcSxeDhgy2FmLk1o1nR0sUa6VZn7 X-Received: by 2002:a17:902:9047:: with SMTP id w7mr8352438plz.270.1542832174939; Wed, 21 Nov 2018 12:29:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542832174; cv=none; d=google.com; s=arc-20160816; b=THjY8q1ugN9niVOVaIhhX/E+fMRd9a1xf5Rn4J7wLMRqmxf/X0P6m017KmyPX6kg/Q vnN9ihTh7MWPebjOvt5Ms2Wv/w19Pogd7jnNWgrg4qFCYwCLpjnUPbluGeERoSoSsO1F GNFRcvaA+cfhKp0UuCxZTVJnpzxaBqr+l6Wtpkjq6bcqHBAmwiFRudEbKGXvNfFa2OzO 6ms+yNeWElS66o+bNK33aRhzSSVzWBSWo/9kE7YWlk493BkNImcbq7DHTpeAOZhT9hoX zBlhg8oSPWsrVPlrPci+anqhEIUACd/5poGZzdWgpud3sk92hFwp74Rs6fFJLcmuqVzY /AWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=u53Fy3PFQgrXsa9Cw9WDaErhn0Oytc+KxZBQBLc+q2w=; b=kM1dgTK60YebGGwohFdRZpxf2jll8bcsoYeF6E05t7UB1mGlfEPwqtW66byQciNmcq 8fjTH71BQ+wjqgUfE5ODxQfLX7me1sOY0SOuwPZXq9S9lsulOETPfMIZqoeS9c21PFYM 8ly5S5bI7VjD9P7l/l+gSSRnl5vFCc1v6pHMSHgJvA7EjzuRqX4ZQ4/bWU9MVyBFywI1 nbMrVIakFSIclLgS5YmfODqsntsZkCtiJ/oVZ8eA4C9ReO9fb6DfJdzfChUntUtETKvA BKFM1zAao7uVaPoR4MSgOhWI+wL9z5wtzF8XJI6NTnQneMPzPxYj4bbVwzTlpRmy+URO Gwcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o13si14612068pgp.540.2018.11.21.12.29.19; Wed, 21 Nov 2018 12:29:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731326AbeKVEs7 (ORCPT + 99 others); Wed, 21 Nov 2018 23:48:59 -0500 Received: from www.osadl.org ([62.245.132.105]:36197 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730877AbeKVEs7 (ORCPT ); Wed, 21 Nov 2018 23:48:59 -0500 Received: from debian01.hofrr.at (178.115.242.59.static.drei.at [178.115.242.59]) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id wALI9BFN006464; Wed, 21 Nov 2018 19:09:16 +0100 From: Nicholas Mc Guire To: Linus Walleij Cc: Bartosz Golaszewski , Matthias Brugger , Sergio Paracuellos , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Nicholas Mc Guire Subject: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack Date: Wed, 21 Nov 2018 19:06:13 +0100 Message-Id: <1542823573-20228-2-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1542823573-20228-1-git-send-email-hofrat@osadl.org> References: <1542823573-20228-1-git-send-email-hofrat@osadl.org> X-Spam-Status: No, score=0.4 required=6.0 tests=BAYES_00,DATE_IN_FUTURE_96_Q autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on www.osadl.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error cases of mediatek_gpio_bank_probe() would go unnoticed (except for the dev_err() messages). The probe function should return an error if one of the banks failed to initialize properly. Signed-off-by: Nicholas Mc Guire Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") --- Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y, GPIOLIB=y, GPIO_MT7621=y Patch is against 4.20-rc3 (localversion-next is next-20181121) drivers/gpio/gpio-mt7621.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c index 1ec95bc..68fca8b 100644 --- a/drivers/gpio/gpio-mt7621.c +++ b/drivers/gpio/gpio-mt7621.c @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev) struct device_node *np = dev->of_node; struct mtk *mtk; int i; + int ret; mtk = devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL); if (!mtk) @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev) platform_set_drvdata(pdev, mtk); mediatek_gpio_irq_chip.name = dev_name(dev); - for (i = 0; i < MTK_BANK_CNT; i++) - mediatek_gpio_bank_probe(dev, np, i); + for (i = 0; i < MTK_BANK_CNT; i++) { + ret = mediatek_gpio_bank_probe(dev, np, i); + if (!ret) + return ret; + } return 0; } -- 2.1.4