Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Nov 2018 10:25:29 -0800
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Salil Mehta <salil.mehta@huawei.com>
Cc:     "davem@davemloft.net" <davem@davemloft.net>,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
        "lipeng (Y)" <lipeng321@huawei.com>,
        "mehta.salil@opnsrc.net" <mehta.salil@opnsrc.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH net-next 0/8] net: hns3: Adds support of debugfs to HNS3
 driver
Message-ID: <20181121102529.7d8df6e4@cakuba.netronome.com>
In-Reply-To: <F4CC6FACFEB3C54C9141D49AD221F7F93BFC8A64@FRAEML521-MBX.china.huawei.com>
References: <20181119211845.23168-1-salil.mehta@huawei.com>
        <20181119142955.56b6baa6@cakuba.netronome.com>
        <F4CC6FACFEB3C54C9141D49AD221F7F93BFC8A64@FRAEML521-MBX.china.huawei.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 21 Nov 2018 18:06:19 +0000, Salil Mehta wrote:
> > From: Jakub Kicinski [mailto:jakub.kicinski@netronome.com]
> > Sent: Monday, November 19, 2018 10:30 PM
> > To: Salil Mehta <salil.mehta@huawei.com>
> > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen) <yisen.zhuang@huawei.com>;
> > lipeng (Y) <lipeng321@huawei.com>; mehta.salil@opnsrc.net;
> > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm
> > <linuxarm@huawei.com>
> > Subject: Re: [PATCH net-next 0/8] net: hns3: Adds support of debugfs to
> > HNS3 driver
> > 
> > On Mon, 19 Nov 2018 21:18:37 +0000, Salil Mehta wrote:  
> > > This patchset adds support of debugfs to the HNS3 driver.
> > >
> > > Support has been added to query info related to below items:
> > > 1. Queue related
> > > 2. Flow Director
> > > 3. TC config
> > > 4. Transmit Module/Scheduler
> > > 5. QoS pause
> > > 6. QoS buffer
> > > 7. QoS prio map  
> > 
> > Please provide a more informative cover letter.
> > 
> > From a short glance it looks like you add a single debugfs file, which
> > can be written to, and upon that write the driver will dump stuff into
> > kernel logs.  
> 
> That is correct. Do you foresee any problem with it or are we doing something
> which is objectionable?

Its fine with me, but I think not everyone reading the list will read
the code so a few extra words and adding one of the examples from the
patches to the cover letter could help people understand the changes.