Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp186847imu; Wed, 21 Nov 2018 17:51:09 -0800 (PST) X-Google-Smtp-Source: AJdET5fjfzgwHPQ9d+yzUyc6gSQ7Qcbfpei0BOrppt6sFaxw1/MM2EyKlRqgQukTAZ9Le346MQ61 X-Received: by 2002:a62:8dd9:: with SMTP id p86mr9246256pfk.143.1542851469214; Wed, 21 Nov 2018 17:51:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542851469; cv=none; d=google.com; s=arc-20160816; b=X1ZL4b30D2NOuUWOCNUt7nIbBlk600aCt9E9C2uPj0S6NB0qcOr/G/myE7CngISVpv u/CFaxib5Bfq2YOgbKAswH3/0aCsOh8bnf8qjOC0RHwy8hKVX3kGFbtG+864X604BI3i PoL9/MUs7g1byO8ZCrXAll/Qvapa3+jYSDabzS99PnzpNc3/AgFPVwj8OTp/TRRMh9yS U6HwOT+k28YcdJ5st916CxtJgGzX7OS0kGpi3ZQmicLOx89/EW2P1T75uwX3/vwAQFzV x0jl+1SYtVjC+2f9Df2g7nMI+NcKkuQhPm3ZMRa8KPbKxPKajHnZ+4fOvAWVUE/XG1xA msEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GPpSvu7F+Z8aXNIIlSz61Y4f42QLtLRfEL96sMgwW0w=; b=QfBdT9IAm/Q77z9HFhoqMJvnoE7N09FjW5rroqm3/o/yiu2LcYUCNpjbm/YeowWC4U 4nAYLETsOvJaz7Fr701zYwCZDUhaiJJVNVl9dxp101qvsACEPEU7mUaTGZDVaQGXGVaj QR8lsNRakeal6O0B7GHMUg1RPGumYUVM/V/X65lN3POhnSGms1My9VIdlTfW6LyzZMPW 2897sDYiDdvE2tHLQUhYQAqzEAuDQIUYiDvECfS0QHD0MLFh0Zy0H1BsMmO/PM6e+e9I 8gEd3SZlJOfOR6EwWy3PWJ7fV3pcwEtB/EC2svqTC3PjZ9eOQtYTOzzsID7QLB1s4NKn FZVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dNq+gQqU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m124-v6si28647629pfb.258.2018.11.21.17.50.54; Wed, 21 Nov 2018 17:51:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dNq+gQqU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388961AbeKVFqz (ORCPT + 99 others); Thu, 22 Nov 2018 00:46:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:42192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732083AbeKVFqu (ORCPT ); Thu, 22 Nov 2018 00:46:50 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C056821527; Wed, 21 Nov 2018 19:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542827477; bh=Br7QiHE31YkE8rnF11nBGLHweItGSQ6SkhGIjZAb4/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dNq+gQqUad6BaPHwfu3BfFLckR2A61UlwWW554cyXao5dGUnXXc9ox1Jga5VEWLVP npebcygkIgkyPTl73kdvTueqvCSBLvpNFDEn9o9RwnSg9BGhTJsl2se+jAfPi5aLtj /mSeuAcagcULrVge3RAnW6LMcnvzF7YXjYIgXXW0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marc Zyngier , Russell King , Tony Lindgren , "David A. Long" Subject: [PATCH 4.9 47/59] ARM: KVM: invalidate icache on guest exit for Cortex-A15 Date: Wed, 21 Nov 2018 20:07:02 +0100 Message-Id: <20181121183510.122684916@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181121183508.262873520@linuxfoundation.org> References: <20181121183508.262873520@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marc Zyngier Commit 0c47ac8cd157727e7a532d665d6fb1b5fd333977 upstream. In order to avoid aliasing attacks against the branch predictor on Cortex-A15, let's invalidate the BTB on guest exit, which can only be done by invalidating the icache (with ACTLR[0] being set). We use the same hack as for A12/A17 to perform the vector decoding. Signed-off-by: Marc Zyngier Signed-off-by: Russell King Boot-tested-by: Tony Lindgren Reviewed-by: Tony Lindgren Signed-off-by: David A. Long Signed-off-by: Greg Kroah-Hartman --- arch/arm/include/asm/kvm_mmu.h | 5 +++++ arch/arm/kvm/hyp/hyp-entry.S | 24 ++++++++++++++++++++++++ 2 files changed, 29 insertions(+) --- a/arch/arm/include/asm/kvm_mmu.h +++ b/arch/arm/include/asm/kvm_mmu.h @@ -257,6 +257,11 @@ static inline void *kvm_get_hyp_vector(v return kvm_ksym_ref(__kvm_hyp_vector_bp_inv); } + case ARM_CPU_PART_CORTEX_A15: + { + extern char __kvm_hyp_vector_ic_inv[]; + return kvm_ksym_ref(__kvm_hyp_vector_ic_inv); + } #endif default: { --- a/arch/arm/kvm/hyp/hyp-entry.S +++ b/arch/arm/kvm/hyp/hyp-entry.S @@ -73,6 +73,28 @@ __kvm_hyp_vector: #ifdef CONFIG_HARDEN_BRANCH_PREDICTOR .align 5 +__kvm_hyp_vector_ic_inv: + .global __kvm_hyp_vector_ic_inv + + /* + * We encode the exception entry in the bottom 3 bits of + * SP, and we have to guarantee to be 8 bytes aligned. + */ + W(add) sp, sp, #1 /* Reset 7 */ + W(add) sp, sp, #1 /* Undef 6 */ + W(add) sp, sp, #1 /* Syscall 5 */ + W(add) sp, sp, #1 /* Prefetch abort 4 */ + W(add) sp, sp, #1 /* Data abort 3 */ + W(add) sp, sp, #1 /* HVC 2 */ + W(add) sp, sp, #1 /* IRQ 1 */ + W(nop) /* FIQ 0 */ + + mcr p15, 0, r0, c7, c5, 0 /* ICIALLU */ + isb + + b decode_vectors + + .align 5 __kvm_hyp_vector_bp_inv: .global __kvm_hyp_vector_bp_inv @@ -92,6 +114,8 @@ __kvm_hyp_vector_bp_inv: mcr p15, 0, r0, c7, c5, 6 /* BPIALL */ isb +decode_vectors: + #ifdef CONFIG_THUMB2_KERNEL /* * Yet another silly hack: Use VPIDR as a temp register.