Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Nov 2018 15:56:34 -0500
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Nadav Amit <namit@vmware.com>, linux-kernel@vger.kernel.org
Subject: Out of tree module build errors since v4.20-rc1
Message-ID: <20181121205633.oxksehwjg5a2q6rt@oracle.com>
Mail-Followup-To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Nadav Amit <namit@vmware.com>, linux-kernel@vger.kernel.org
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


My out of tree driver build is now reporting issues with the jump table:

=2E/include/linux/jump_label.h: In function =E2=80=98jump_entry_code=E2=80=
=99:
=2E/include/linux/jump_label.h:153:14: error: dereferencing pointer to inco=
mplete type =E2=80=98const struct jump_entry=E2=80=99
  return entry->code;
              ^~
=2E/include/linux/jump_label.h: In function =E2=80=98jump_entry_set_init=E2=
=80=99:
=2E/include/linux/jump_label.h:180:7: error: dereferencing pointer to incom=
plete type =E2=80=98struct jump_entry=E2=80=99
  entry->key |=3D 2;
       ^~
=2E/include/linux/jump_label.h: At top level:
=2E/include/linux/jump_label.h:212:26: error: array type has incomplete ele=
ment type =E2=80=98struct jump_entry=E2=80=99
 extern struct jump_entry __start___jump_table[];
                          ^~~~~~~~~~~~~~~~~~~~
=2E/include/linux/jump_label.h:213:26: error: array type has incomplete ele=
ment type =E2=80=98struct jump_entry=E2=80=99
 extern struct jump_entry __stop___jump_table[];
                          ^~~~~~~~~~~~~~~~~~~


This happens in v4.20-rc3 as well, so I bisected between v4.19 to
v4.20-rc1 which resulted in the following commit:

b34006c4258c9c86597b6b7123d6a9a3513d6cd7 is the first bad commit
commit b34006c4258c9c86597b6b7123d6a9a3513d6cd7
Author: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Tue Sep 18 23:51:41 2018 -0700

    x86/jump_table: Use relative references


Initially I assumed this was my own fault, but my module does not have
these issues when using v4.19.  Is there anything I should try/change in
my module makefile, includes, etc to support this relative reference
code?


Thank you,
Liam