Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp502738imu; Thu, 22 Nov 2018 00:40:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/VJgSCxwRDNMKpWioFhKpndpe36fbCP3VCWX+pfg3oXNJo86Me4Zr4Zs1jyYMihjwTSGzve X-Received: by 2002:a17:902:5a86:: with SMTP id r6mr10019667pli.301.1542876034242; Thu, 22 Nov 2018 00:40:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542876034; cv=none; d=google.com; s=arc-20160816; b=oYcuw+1pknUUk9LlTLgS8+UnOp5z8eS0dh3MCAWInUGnoTIrM9ey7y1IoebWezb1/o wjiZccJqpy0lOYFtEPiEYQu7YhMLhr6uBXqdQ7xexe/C1z2XjD4ynZ0UORtw5io3232p +2j3N7DlINnNo6Co4B496z3Ss9R7wqCi/MLWHRkNoevhwq+O6Z70JRQea6sR431AfHh8 gxzHsOK1/XWJkeRGNsvdnRchO17xv5THtA3bddcTK6baF0Q8pLolWrIXvvz33Mk1UNHX SOg1HDaVyiH0O9FIKI9nysnWx5jk+Jzsy1aJExzhOXzDGuYfmY7DOsl6vlsV6woqcXfg elPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1VEYE8AYKWMorcMRVdBvCicCcdIwPJJhQJfF/v55zvA=; b=dMqLjIisddkx/hDV1FeWIH2EIgT1rDNrpXKHlzP6/EWG0c/1txkfq39HZAVasrL686 5GScguE0XD0LagWwo6z0jzJUPc40Mmq5y5By/KDUH5gtQ2vbLfjrGgKmMtKsb9kQdMmU uXbqy17ekZFK3h6jU9DbzDxNLagmqWqEGAlTFEdzmqcr8CaHtGjv7JbSLN0i+NJiI9Xe LBpPDseaGEucSDP09ugbIUILsNAqSp/cPSrKNag3WmpiwQbSXe/kmgewx5OWhOGOhT/O piMAHbZcCMHaad4VkwwQnYqFNbBmt7VplDzYpHfz6k2eu4EYNzCKhzRBokD/LEBbv5ID hR+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=l3q8bmYS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z14si50413568pgz.180.2018.11.22.00.40.19; Thu, 22 Nov 2018 00:40:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=l3q8bmYS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389963AbeKVIrO (ORCPT + 99 others); Thu, 22 Nov 2018 03:47:14 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:47594 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387621AbeKVIrO (ORCPT ); Thu, 22 Nov 2018 03:47:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1VEYE8AYKWMorcMRVdBvCicCcdIwPJJhQJfF/v55zvA=; b=l3q8bmYSAP0C4J0SX/eBkeyYI 6q1G4j4F1WHUK+XfeCBDaRPFepLiwNySLDXsJou+eJDF5MApqp4LQw3WW3Jf1GTrD8MHjlVgsWEiM jauN1tEcNyiSYEYVb0iyNLnLRZ8CXfA/IY91VqorrMWDjAuSLE3qUklZAWXMuSd8QDZ5BmqJ4vLDu C+HdgSLxnZLRyr5Fr2fKni6pJZAxGNY+OUitgtK90lvJQbFzMLLHKy7po6WyimBReFOxMUEYxB/vZ io9QGqK58sX/FlFINnc1lLsagJWfpK2aYqOy7DFOR82lRVxRFuUNRkovxREAQR8sffjqIA1hnfeJu vJjksTSDw==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gPai4-0005HQ-Ge; Wed, 21 Nov 2018 22:11:00 +0000 Date: Wed, 21 Nov 2018 14:11:00 -0800 From: Matthew Wilcox To: Yu Zhao Cc: Hugh Dickins , Andrew Morton , stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm: use swp_offset as key in shmem_replace_page() Message-ID: <20181121221100.GM3065@bombadil.infradead.org> References: <20181119010924.177177-1-yuzhao@google.com> <20181121215442.138545-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181121215442.138545-1-yuzhao@google.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 21, 2018 at 02:54:42PM -0700, Yu Zhao wrote: > We changed key of swap cache tree from swp_entry_t.val to > swp_offset. Need to do so in shmem_replace_page() as well. > > Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap cache") > Cc: stable@vger.kernel.org # v4.9+ > Signed-off-by: Yu Zhao Reviewed-by: Matthew Wilcox