Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Nov 2018 23:34:53 +0100
From:   Andrea Parri <andrea.parri@amarulasolutions.com>
To:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>
Cc:     linux-kernel@vger.kernel.org
Subject: [Question] atomic_fetch_andnot() in nohz_idle_balance()
Message-ID: <20181121223453.GA4016@andrea>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

The comment for the atomic_fetch_andnot() in nohz_idle_balance() says:

  "barrier, pairs with nohz_balance_enter_idle(), ensures ..."

which, well, does sound a note of warning... ;-)

I see that nohz_balance_enter_idle() has an smp_mb__after_atomic() but
the comment for the latter suggests that this barrier is pairing with
the smp_mb() in _nohz_idle_balance().

So, what is the intended pairing barrier for the atomic_fetch_andnot()?
what (which memory accesses) do you want "to order" here?

Thanks,
  Andrea