Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAEUhbmWskEtQR-kAuAYx=SHOJ4-MrCRUchSQ68WwZ62hxsTQyQ@mail.gmail.com>
 <mhng-7be4f47d-bc3a-4073-a6db-dc5588304d2d@palmer-si-x1c4>
In-Reply-To: <mhng-7be4f47d-bc3a-4073-a6db-dc5588304d2d@palmer-si-x1c4>
From:   Bin Meng <bmeng.cn@gmail.com>
Date:   Thu, 22 Nov 2018 09:43:12 +0800
Message-ID: <CAEUhbmW08WfTQRVSAaC6SRWhZmrUTAm9b8wefuMMbg8dGeKZVA@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Build flat and compressed kernel images
To:     palmer@sifive.com
Cc:     Anup Patel <anup@brainfault.org>, aou@eecs.berkeley.edu,
        hch@infradead.org, atish.patra@wdc.com,
        linux-riscv@lists.infradead.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Palmer,

On Thu, Nov 22, 2018 at 12:28 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Tue, 20 Nov 2018 21:06:18 PST (-0800), bmeng.cn@gmail.com wrote:
> > On Mon, Nov 12, 2018 at 1:55 PM Anup Patel <anup@brainfault.org> wrote:
> >>
> >> This patch extends Linux RISC-V build system to build and install:
> >> Image - Flat uncompressed kernel image
> >> Image.gz - Flat and GZip compressed kernel image
> >>
> >> Quiet a few bootloaders (such as Uboot, UEFI, etc) are capable of
> >
> > nits: U-Boot
> >
> >> booting flat and compressed kernel images. In case of Uboot, booting
> >
> > nits: U-Boot
>
> Thanks for the review.  The PR has already been tagged, but it's not scheduled
> to be sent out until later today.  I generally try to avoid rewriting the tags
> unless there's something major that's wrong, so unless you feel very strongly
> about this then I think I'll let it stand.
>
> Let me know if this is a big deal for you, I can rewrite things.
>
> >> Image or Image.gz is achieved using bootm command.
> >>
> >> The flat and uncompressed kernel image (i.e. Image) is very useful
> >> in pre-silicon developent and testing because we can create back-door
> >> HEX files for RAM on FPGAs from Image.
> >>
> >> Signed-off-by: Anup Patel <anup@brainfault.org>
> >> ---
> >>  arch/riscv/Makefile             | 15 ++++++++-
> >>  arch/riscv/boot/.gitignore      |  2 ++
> >>  arch/riscv/boot/Makefile        | 33 ++++++++++++++++++
> >>  arch/riscv/boot/install.sh      | 60 +++++++++++++++++++++++++++++++++
> >>  arch/riscv/kernel/head.S        | 10 ++++++
> >>  arch/riscv/kernel/vmlinux.lds.S |  2 +-
> >>  6 files changed, 120 insertions(+), 2 deletions(-)
> >>  create mode 100644 arch/riscv/boot/.gitignore
> >>  create mode 100644 arch/riscv/boot/Makefile
> >>  create mode 100644 arch/riscv/boot/install.sh
> >>
> >
> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> >
> > Tested with U-Boot s-mode on QEMU virt, using bootm to boot the kernel
> > Tested-by: Bin Meng <bmeng.cn@gmail.com>
>
> I also won't include the tags unless I rewrite the tags.
>
> Thanks for the review!

Thanks. Let's go with this as it's a minor nits.

Regards,
Bin