Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Nov 2018 19:28:44 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Yafang Shao <laoar.shao@gmail.com>
Cc:     adobriyan@gmail.com, viro@zeniv.linux.org.uk,
        keescook@chromium.org, orcunov@openvz.org,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] procfs: fix the output format in /proc/PID/wchan
Message-Id: <20181121192844.1cd1c2fa4801a324d059176c@linux-foundation.org>
In-Reply-To: <1542626272-29129-1-git-send-email-laoar.shao@gmail.com>
References: <1542626272-29129-1-git-send-email-laoar.shao@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 19 Nov 2018 19:17:52 +0800 Yafang Shao <laoar.shao@gmail.com> wrote:

> Just add the missing newline.
> 
> ...
>
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -370,11 +370,12 @@ static int proc_pid_wchan(struct seq_file *m, struct pid_namespace *ns,
>  	wchan = get_wchan(task);
>  	if (wchan && !lookup_symbol_name(wchan, symname)) {
>  		seq_puts(m, symname);
> +		seq_putc(m, '\n');
>  		return 0;
>  	}
>  
>  print0:
> -	seq_putc(m, '0');
> +	seq_puts(m, "0\n");
>  	return 0;
>  }
>  #endif /* CONFIG_KALLSYMS */

What is presently wrong with the wchan output?  The changelog
should explain such things, please.

Providing example output with the patch unapplied and then with the
patch applied would help us to understand the patch's effect.

Thanks.