Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1199557imu; Thu, 22 Nov 2018 11:59:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/XBg3GLKBY0/uQxPyCyerJFWIpSUzbrsHNq2oRM3OpzWiDtpnhonQf6DpPSUcGF9hI66eic X-Received: by 2002:a65:5286:: with SMTP id y6mr11182206pgp.439.1542916760009; Thu, 22 Nov 2018 11:59:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542916759; cv=none; d=google.com; s=arc-20160816; b=U5v0N6Aw83ywRldtZHmgcwY464k4KUqZClz/vBTQghRXQz3B6K+vsV2OabMu+FSZ6b sgFj3cwKbkTEc6/IQ4fm54UXRHDBOt/3GxcSPQaKfB5IL/7ESUQUdaR1ICYSHbHqYuQo uPba2ABX0HXOtrBwYDuzT+HOrFQ3r+PWAFNtL5TRGX+RoI9cne30FKF1QsTEkS3pQQFC uw1ctj9uSlkeU02M6Ur35wwK+lXKTh0t9Q9kfRdB6Jg4ZuqbpYXpqIhDbtpbi2vgxYXR uPGevpKgyefJ7iYSb99GMP1IEpbxzonWxCC9NSa7Hs9NVMh8tE71D1uttV7gyjiinzz7 8lxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=meUnql494klCl/eMcKpy8ZTMDrmIlq/cz6iLss1bsXM=; b=gbGnf3/p9isFquZt3Et3LlJwlIYPqTJ80M5MKuXuqugaeTb+KlzEw232cHqg4ovW86 OBrfInQeFIBE6/tYx6gBx4kuQ7INUEqO4hOL/M23Auq49X7gr8vvhSZIVqKnbFnmDkDI 3vPYEd71CFpJjXpwGANZAhj5C7iKngnVJ6igpCin6lc/nHW48wakG/LT0E1QPKFju7uz uxdDW8+CM3S1uLRVV1nFNTeJMwykzwl8HvdapqTwhWp0wOw7MSMNNdfJWggGOlinIccp y7aY6j4Fjaxrm2ZUtOe2+ksO+pvno4j9LT/UexLWIG5xtOd1w0FIh27/rc9D4fJiVV3t 3i3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p2-v6si55792353pfp.82.2018.11.22.11.59.05; Thu, 22 Nov 2018 11:59:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389700AbeKVSXN (ORCPT + 99 others); Thu, 22 Nov 2018 13:23:13 -0500 Received: from mail.bootlin.com ([62.4.15.54]:44121 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729423AbeKVSXM (ORCPT ); Thu, 22 Nov 2018 13:23:12 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id C256F20D29; Thu, 22 Nov 2018 08:44:57 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from windsurf (aaubervilliers-681-1-94-205.w90-88.abo.wanadoo.fr [90.88.35.205]) by mail.bootlin.com (Postfix) with ESMTPSA id 8BE7D20714; Thu, 22 Nov 2018 08:44:57 +0100 (CET) Date: Thu, 22 Nov 2018 08:44:57 +0100 From: Thomas Petazzoni To: YueHaibing Cc: , , Subject: Re: [PATCH net-next] net: mvneta: remove redundant check for eee->tx_lpi_timer < 0 Message-ID: <20181122084457.2eb1adc9@windsurf> In-Reply-To: <20181122064200.11572-1-yuehaibing@huawei.com> References: <20181122064200.11572-1-yuehaibing@huawei.com> Organization: Bootlin (formerly Free Electrons) X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, 22 Nov 2018 14:42:00 +0800, YueHaibing wrote: > fixes the smatch warning: > > drivers/net/ethernet/marvell/mvneta.c:4252 mvneta_ethtool_set_eee() warn: > unsigned 'eee->tx_lpi_timer' is never less than zero. > > Signed-off-by: YueHaibing Acked-by: Thomas Petazzoni Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com