Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181121231827.GA9573@myunghoj-Precision-5530>
In-Reply-To: <20181121231827.GA9573@myunghoj-Precision-5530>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Thu, 22 Nov 2018 10:20:56 +0100
Message-ID: <CAJfpegv8sfny0FG=DAb4AU3ecBYDG_WqVTVBCOt9HTVeQFNeaQ@mail.gmail.com>
Subject: Re: [PATCH] fuse: Add bad inode check in fuse_destroy_inode()
To:     mhjungk@gmail.com
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 22, 2018 at 12:18 AM Myungho Jung <mhjungk@gmail.com> wrote:
>
> make_bad_inode() sets inode->i_mode to S_IFREG if I/O error is detected
> in fuse_do_getattr()/fuse_do_setattr(). If the inode is not a regular
> file, write_files and queued_writes in fuse_inode are not initialized
> and have NULL or invalid pointers written by other members in a union.
> So, list_empty() returns false in fuse_destroy_inode(). Add
> is_bad_inode() to check if make_bad_inode() was called.
>
> Reported-by: syzbot+b9c89b84423073226299@syzkaller.appspotmail.com
> Signed-off-by: Myungho Jung <mhjungk@gmail.com>

Thanks, applied.

Miklos