Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262580AbUAMAHG (ORCPT ); Mon, 12 Jan 2004 19:07:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262598AbUAMAHG (ORCPT ); Mon, 12 Jan 2004 19:07:06 -0500 Received: from orion.netbank.com.br ([200.203.199.90]:8967 "EHLO orion.netbank.com.br") by vger.kernel.org with ESMTP id S262580AbUAMAHB (ORCPT ); Mon, 12 Jan 2004 19:07:01 -0500 Date: Mon, 12 Jan 2004 22:17:46 -0200 From: Arnaldo Carvalho de Melo To: Adrian Bunk Cc: linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] fix a drivers/char/isicom.c compile warning Message-ID: <20040113001746.GN18853@conectiva.com.br> Mail-Followup-To: Arnaldo Carvalho de Melo , Adrian Bunk , linux-kernel@vger.kernel.org References: <20040113000055.GU9677@fs.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040113000055.GU9677@fs.tum.de> X-Url: http://advogato.org/person/acme Organization: Conectiva S.A. User-Agent: Mutt/1.5.5.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1522 Lines: 49 Em Tue, Jan 13, 2004 at 01:00:56AM +0100, Adrian Bunk escreveu: > I got the following compile warning in 2.6.1-mm2 (but it doesn't seem to > be specific to -mm): > > > <-- snip --> > > ... > CC [M] drivers/char/isicom.o > ... > drivers/char/isicom.c: In function `unregister_drivers': > drivers/char/isicom.c:1677: warning: `error' might be used uninitialized in this function > ... > > <-- snip --> > > > The following patch fixes this issue: > > > --- linux-2.6.1-mm2-modular-no-smp/drivers/char/isicom.c.old 2004-01-13 00:40:02.000000000 +0100 > +++ linux-2.6.1-mm2-modular-no-smp/drivers/char/isicom.c 2004-01-13 00:49:00.000000000 +0100 > @@ -1675,7 +1675,7 @@ > static void unregister_drivers(void) > { > int error; > - if (tty_unregister_driver(isicom_normal)) > + if ((error=tty_unregister_driver(isicom_normal))) > printk(KERN_DEBUG "ISICOM: couldn't unregister normal driver error=%d.\n",error); OK, the patch is right, but couldn't we take the opportunity to make this more readable while at it? Ssomething like: static void unregister_drivers(void) { int error = tty_unregister_driver(isicom_normal); if (error) printk(KERN_DEBUG "ISICOM: couldn't unregister normal " "driver error=%d.\n", error); ? :-) - Arnaldo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/