Date: Mon, 12 Jan 2004 22:38:28 -0200
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fix a drivers/char/isicom.c compile warning
Message-ID: <20040113003828.GO18853@conectiva.com.br>
Mail-Followup-To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
	Adrian Bunk <bunk@fs.tum.de>, linux-kernel@vger.kernel.org
References: <20040113000055.GU9677@fs.tum.de> <20040113001746.GN18853@conectiva.com.br> <20040113002318.GV9677@fs.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040113002318.GV9677@fs.tum.de>
Organization: Conectiva S.A.
User-Agent: Mutt/1.5.5.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2028
Lines: 46

Em Tue, Jan 13, 2004 at 01:23:18AM +0100, Adrian Bunk escreveu:
> On Mon, Jan 12, 2004 at 10:17:46PM -0200, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jan 13, 2004 at 01:00:56AM +0100, Adrian Bunk escreveu:
> >...
> > > The following patch fixes this issue:
> > > 
> > > 
> > > --- linux-2.6.1-mm2-modular-no-smp/drivers/char/isicom.c.old	2004-01-13 00:40:02.000000000 +0100
> > > +++ linux-2.6.1-mm2-modular-no-smp/drivers/char/isicom.c	2004-01-13 00:49:00.000000000 +0100
> > > @@ -1675,7 +1675,7 @@
> > >  static void unregister_drivers(void)
> > >  {
> > >  	int error;
> > > -	if (tty_unregister_driver(isicom_normal))
> > > +	if ((error=tty_unregister_driver(isicom_normal)))
> > >  		printk(KERN_DEBUG "ISICOM: couldn't unregister normal driver error=%d.\n",error);
> > 
> > OK, the patch is right, but couldn't we take the opportunity to make this
> > more readable while at it? Ssomething like:
> > 
> > static void unregister_drivers(void)
> > {
> >         int error = tty_unregister_driver(isicom_normal);
> > 
> >         if (error)
> > 		printk(KERN_DEBUG "ISICOM: couldn't unregister normal "
> > 				  "driver error=%d.\n", error);
> > 
> > ? :-)
> 
> I thought about it, but I wasn't sure whether changing a driver to be 
> more readable in _one_ place and making the code there different from 
> the coding style used in the rest of the driver is really an 
> improvement (and no, I don't want to clean the whole driver...)?

Humm, IMHO it is better to get it with mixed style as long as the changes that
"break" the style are for the correct style, but this, of course, for purely
unmaintained stuff, like... isicom.c :-) For maintained stuff it becomes a
pain in the ass for the maintainer, that should try to follow CodingStyle, but
as we know, not always do.
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/