Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2534622imu; Fri, 23 Nov 2018 10:35:55 -0800 (PST) X-Google-Smtp-Source: AJdET5d/vmXOu47DRitW2syrbY7hADPTT8RJkaeNhPRFe4IbgO9PIOz6dQsXNFKAk9tasDoNKVD3 X-Received: by 2002:aa7:868f:: with SMTP id d15mr16859332pfo.225.1542998155139; Fri, 23 Nov 2018 10:35:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542998155; cv=none; d=google.com; s=arc-20160816; b=JQ/a/W2GskNvoPKnbIheZll5Hi2ZQEXX25QJ9MQO2q5U1pG9Y7eXZNaLfNF7qvLMQw eaJcoNK00kvbnZisaLmlxpzGBovlkkWQZKcGsxFeOx97xFVj4y4qH8zfqvUwHVfa7BTM puqEjrVtJdLDPZffcdY3aM6aVPoxgIySjMhwxBQVzsar/ylpwTW2WtgOJs1k8Tosk+cM WksUFsiNzD2PrE81yKIPsEj7NpiHZd0rNuF9ewt+WFxm7Tm/PJXzMj03unXOhgp+2UlP Jb0Or7fasgzRzoPexf01CDUSGt2qRqXFaQk8WeA0dxRjc29ECcywWxvrY+1jdJw0MV6G blMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NRkfp6v/tyUENHy0v3FTFCa7RE2ArNmx9O95c3iBPt0=; b=0V3pWVJbPXEWod0sX/bRJe6ixJfxhnaGV1XzdQUGXc78sfn2AbzmxYepKzPvyWSUTO F6McKRp+3b79ZKuvcjo1gQjCejGwevfvJJaIfV2k4PEVmmkRVgyWq+hFzdTJzkr7GOL5 xpbm/vPgFa0QgVBWWBXitMoDtXyd9qYR4Nc1Z3zdgpsYZxZBGUciGMLB6IEuPuL9bu6/ DCApCuUsvs+GlOWMqXWluaZB5gRJs3o16dfsdN0paoch1IS1+Vu2ee655q5O7UOflj0F /QZoufqwNd2my9IvtBGzTR1sOsrcDmpMfjL1S+toxE1SYjzqB9NBWo5NqVJ8SoNDSuXt SMrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=BhkyanM6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t74si43475593pgc.150.2018.11.23.10.35.40; Fri, 23 Nov 2018 10:35:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=BhkyanM6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437232AbeKWAnm (ORCPT + 99 others); Thu, 22 Nov 2018 19:43:42 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:59632 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731181AbeKWAnm (ORCPT ); Thu, 22 Nov 2018 19:43:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NRkfp6v/tyUENHy0v3FTFCa7RE2ArNmx9O95c3iBPt0=; b=BhkyanM6gWSsCuX6iaFbuGduoS toCX63m7RIQFNq2vYWjKqhgQG9FSqxcmCclgXpsAg00C8mB3yKFH4SOihjFdqi+a1JGZl6dPQVecj E4A5VsMJbV/K6cmXiC2TZmRbdllLX8hh0j78WQfaUdGl81tMwDtE2zzDb8TIVI4QQ/ivyA8f2hfxf Zt4KbhSd/BULRcE97LNe3BgAHJdGlgfOa0zBls4RZfUvb2K/gDEiySPOq4dcbYDHKYIXYi2rOddNz AaHQtQkDL9QEL8nPchcZNwFn/QTysKBSgf/ZWInsLotPdCEpgkF5hN5ArlIfSpuApg1IC/KEX/BvL EYMbkiww==; Received: from clnet-p19-102.ikbnet.co.at ([83.175.77.102] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gPpaK-0008Ki-OC; Thu, 22 Nov 2018 14:04:01 +0000 From: Christoph Hellwig To: iommu@lists.linux-foundation.org Cc: Linus Torvalds , Jon Mason , Joerg Roedel , David Woodhouse , Marek Szyprowski , Robin Murphy , x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/24] arm64: remove the dummy_dma_ops mapping_error method Date: Thu, 22 Nov 2018 15:03:08 +0100 Message-Id: <20181122140320.24080-13-hch@lst.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181122140320.24080-1-hch@lst.de> References: <20181122140320.24080-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just return DMA_MAPPING_ERROR from __dummy_map_page and let the core dma-mapping code handle the rest. Signed-off-by: Christoph Hellwig --- arch/arm64/mm/dma-mapping.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index a3ac26284845..fdc26ea5036c 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -282,7 +282,7 @@ static dma_addr_t __dummy_map_page(struct device *dev, struct page *page, enum dma_data_direction dir, unsigned long attrs) { - return 0; + return DMA_MAPPING_ERROR; } static void __dummy_unmap_page(struct device *dev, dma_addr_t dev_addr, @@ -317,11 +317,6 @@ static void __dummy_sync_sg(struct device *dev, { } -static int __dummy_mapping_error(struct device *hwdev, dma_addr_t dma_addr) -{ - return 1; -} - static int __dummy_dma_supported(struct device *hwdev, u64 mask) { return 0; @@ -339,7 +334,6 @@ const struct dma_map_ops dummy_dma_ops = { .sync_single_for_device = __dummy_sync_single, .sync_sg_for_cpu = __dummy_sync_sg, .sync_sg_for_device = __dummy_sync_sg, - .mapping_error = __dummy_mapping_error, .dma_supported = __dummy_dma_supported, }; EXPORT_SYMBOL(dummy_dma_ops); -- 2.19.1