Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2613199imu; Fri, 23 Nov 2018 11:56:07 -0800 (PST) X-Google-Smtp-Source: AJdET5fBhZ/F+fHaS50aGqu731rFyuK8K40zR9sLTT9rg4iIAWp5GWEvLrmWQo7xGLIbldFpcy8G X-Received: by 2002:a62:a1a:: with SMTP id s26mr17351546pfi.31.1543002967069; Fri, 23 Nov 2018 11:56:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543002967; cv=none; d=google.com; s=arc-20160816; b=g2OMWREf8pWDI0nO2me8Z0cgOLbHT3qJCoiZNGsF9bK8zHFZyWWbV4snB9aobL0E7k vQyCJsz+CXtXSzbwcrnXDVY4F+fhXLtO+G5limStXxA/PgbF/m2FgbqiZmRfpofzn0jZ 2QXLc+0ftyxC/dY4OhS/OCw+ktiM1OK60wVq6eCJxfY1AZs4kBzXsxago1YNNI3UiWb5 9s9ONsVuC0fycEax6ghFzxgkDyrNLynnMvXOVYnnY38U6zqQ6AFps6FdQtKIx9AzRogY y9qUbvVNQSHEC3RlDALTzwbwejTs7p3W2ZPac/PzpTBKOjadCDWigOQhbk0hx2gsfQUT SbAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=qP+J0F3WwvPSsTyOSp+vz7pd8wBpOANt9K8FgRe2arc=; b=InljQRvRTa1MpNlda09/NqqcwzKFZzcFxVlgri7BU6lCBs9JSPNs2d4snXR8JCWd7Q NkjZ0R5RXZ8GNGl9Gy0OFANOBVJjcO2sbW5kVl9B6fC7eJ0/ZT4UUzdXeVFyMREyikZy nGirTlksRyDtuf1H6oxthzpdatugFb27dibgKeSPvbZ40+9CG73ejfvgDzVZaHHqbvwA 7jpVhtYj/8dMRWPnYrVSWsSf2sjmU2/6yXlAKyjcRViGaTTeOwMxRbpqYQvBon4fQlFA viJVhsutGzhT6vsUyWf2C8t+40/ZzA5lWswR0C30HSEK/chOYTkAok9f2ib8Xfg4xC0W Leng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z186si51647793pgd.90.2018.11.23.11.55.52; Fri, 23 Nov 2018 11:56:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437448AbeKWAzS (ORCPT + 99 others); Thu, 22 Nov 2018 19:55:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:33588 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389047AbeKWAzR (ORCPT ); Thu, 22 Nov 2018 19:55:17 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 81C2FADE3; Thu, 22 Nov 2018 14:15:43 +0000 (UTC) From: Petr Mladek To: Martin Schwidefsky , Heiko Carstens Cc: Sergey Senozhatsky , Steven Rostedt , Sergey Senozhatsky , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Mladek Subject: [PATCH] s390: Remove obsolete bust_spinlock() implementation Date: Thu, 22 Nov 2018 15:15:29 +0100 Message-Id: <20181122141529.14933-1-pmladek@suse.com> X-Mailer: git-send-email 2.13.7 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commit cefc8be82403cf ("Consolidate bust_spinlocks()") kept the s390-specific implementation because of the absence of CONFIG_VT. In fact, the only difference was calling console_unblank() instead of unblank_screen(). The common implementation in lib/bust_spinlocks.c started to call unblank_screen() explicitly since the commit b61312d353da187 ("oops handling: ensure that any oops is flushed to the mtdoops console"). As a result, the custom implementation is not longer necessary. And we could get all the other improvements of the common implementation for free. Signed-off-by: Petr Mladek --- arch/s390/mm/fault.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c index 2b8f32f56e0c..11613362c4e7 100644 --- a/arch/s390/mm/fault.c +++ b/arch/s390/mm/fault.c @@ -81,30 +81,6 @@ static inline int notify_page_fault(struct pt_regs *regs) return ret; } - -/* - * Unlock any spinlocks which will prevent us from getting the - * message out. - */ -void bust_spinlocks(int yes) -{ - if (yes) { - oops_in_progress = 1; - } else { - int loglevel_save = console_loglevel; - console_unblank(); - oops_in_progress = 0; - /* - * OK, the message is on the console. Now we call printk() - * without oops_in_progress set so that printk will give klogd - * a poke. Hold onto your hats... - */ - console_loglevel = 15; - printk(" "); - console_loglevel = loglevel_save; - } -} - /* * Find out which address space caused the exception. * Access register mode is impossible, ignore space == 3. -- 2.13.7