Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CGME20181121101410epcas3p27a2a577c3b5a0608f7808ff733fab9d1@epcas3p2.samsung.com>
 <20181121101316.32194-1-ckeepax@opensource.cirrus.com> <c0a2d30d-b18e-e72a-f369-c8678f1854ff@samsung.com>
In-Reply-To: <c0a2d30d-b18e-e72a-f369-c8678f1854ff@samsung.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 22 Nov 2018 15:20:36 +0100
Message-ID: <CACRpkdYjhRUKJnZhSB7y7DzGwYAsZtwv9w339bYQm9VpU23ZZw@mail.gmail.com>
Subject: Re: [PATCH v2] regulator: wm8994: Don't use devres for enable GPIOs
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     Charles Keepax <ckeepax@opensource.cirrus.com>,
        Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        patches@opensource.cirrus.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 21, 2018 at 11:42 AM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:

> Linus, Mark: Similar issue is probably in the other regulator drivers,
> which use enable GPIO allocated by devm_gpio_get*(). This driver is
> simply the first one, which we observed it. It would be great if one
> would take a look into regulator_register() error path, because for some
> cases the GPIO will be freed, for the other - not.

OK I am onto it!

Yours,
Linus Walleij