Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2665922imu; Fri, 23 Nov 2018 12:45:49 -0800 (PST) X-Google-Smtp-Source: AFSGD/XQpsE3nydMEaDrulw4xgEpCg3zk71+gkpXiEvdDkm+G+ruS/4R5UZI7vN0jcyjcG/L/ADm X-Received: by 2002:a17:902:b01:: with SMTP id 1mr9940609plq.331.1543005949315; Fri, 23 Nov 2018 12:45:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543005949; cv=none; d=google.com; s=arc-20160816; b=pXD2kRqYpVdC52Ou0QzvHcuPrsdThd4Em1SqEOws+D2PhP2BThvvtBt15XXIjZaw9z BMVFTxiv072AgdLcqESTh3P/owfcvGHol60n/DOmLSR5p70qi60VfShry/T5rzhWUJo/ P97cwVklQOaEe2bzaNmfGpjE9C0QrEbd/DRNqoHRuaj3lrvuoljXcI0D4cXKiRT+AMCE erVZGZE0bkD9S37R8qClbKXeOakK5pZJ8LzDxgygc7VElC/pxkkgfy/h2uem5UC5Tiic iFh2+9SR1CIKTIoL4IAqQVEoELCJ+8PXIGuazeXQgWpqHoxmPfcYtrtPzuRi90NvdEzt Jf0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=PjIkIVAszAo+I5cK1nkqlJAO1lPtmFDX+VCVCDgwYcA=; b=FCm4fE9o87o5KYQvk04950sws7Bsfr1qeMl4GvCTgriyvEHWxZNIBF5LaIsKZ+Z0un wHoxtFvECVaa7wDWNk8M9knWH2J85cBNIyPpi9pYK8jhKQ9T12zG/FFMcRZtjtYHVe5t KrdQ7+Oc0quF+Xyb4gV+FK2baXpj4W1JknEXVI4nX8HasScCvd7eaf8I3cSC82LA3VNN 7VqU/eqyCsUuhD+FKfnYSW4U6TC2Pkmag4vg9IxEEb8Q+gWhW1So92xJZSdOU6E7YuwF DZRIO2bEj/FVskUQoFy9g1ZzeN+HqcxiJyvvzhlY5dbTnTI0U1BJ2dr+tEr4zg5ipGbF 7V2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9si51954362pgb.105.2018.11.23.12.45.34; Fri, 23 Nov 2018 12:45:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405613AbeKWBXP (ORCPT + 99 others); Thu, 22 Nov 2018 20:23:15 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:42728 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbeKWBXP (ORCPT ); Thu, 22 Nov 2018 20:23:15 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gPqCT-0001Bm-HX; Thu, 22 Nov 2018 22:43:25 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gPqCP-0002vI-8H; Thu, 22 Nov 2018 22:43:21 +0800 Date: Thu, 22 Nov 2018 22:43:21 +0800 From: Herbert Xu To: Mathias Krause Cc: Steffen Klassert , Pan Bian , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: Re: [net] xfrm_user: use xfrm_state_put to free xfrm_state_alloc return value Message-ID: <20181122144321.5gmyynui254qfeoq@gondor.apana.org.au> References: <1542783468-67482-1-git-send-email-bianpan2016@163.com> <20181121080045.4vtozqc6eyeyis2n@gondor.apana.org.au> <20181121200923.GA12460@jig.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181121200923.GA12460@jig.fritz.box> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 21, 2018 at 09:09:23PM +0100, Mathias Krause wrote: > > -- >8 -- > > Subject: [PATCH] xfrm_user: fix freeing of xfrm states on acquire > > Commit 565f0fa902b6 ("xfrm: use a dedicated slab cache for struct > xfrm_state") moved xfrm state objects to use their own slab cache. > However, it missed to adapt xfrm_user to use this new cache when > freeing xfrm states. > > Fix this by introducing and make use of a new helper for freeing > xfrm_state objects. > > Fixes: 565f0fa902b6 ("xfrm: use a dedicated slab cache for struct xfrm_state") > Reported-by: Pan Bian > Cc: # v4.18+ > Signed-off-by: Mathias Krause Acked-by: Herbert Xu Looks good to me. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt