Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3008066imu; Fri, 23 Nov 2018 19:14:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/VSqNdE6au+aloC2rDbYi22bBJzx0gDxH021A79fOkonxUjbYxUmp+47Ho2cb7L4543LAeB X-Received: by 2002:a17:902:8d83:: with SMTP id v3-v6mr18443123plo.162.1543029266984; Fri, 23 Nov 2018 19:14:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543029266; cv=none; d=google.com; s=arc-20160816; b=BdSo3bJAVCOoCs2ed27aS0QBsAEnf1J52QOARHZ4L9uUPgODmtYPyXeYdqBvqE5Jj4 dmefBiuAOPK9NcVQOD45BqchI+3gwz9pMUiTVTD3Y5z+HCnvE0XrQAuSW9yliAJDYBP6 GVyEEXgQin+/n5QmMUnvILqhLSNVc0th918XcVRYCmeN1ilGhsAymMvgMyat9sRDsMS5 93535ZjyUYftxoGREonxB+Kxgvyltf+hBl6q3SLGNv0Tr1dtjUn4lWEmE+2EU7WYn5+v L4DPMHFdPKq7d4jc4HoCYb//onLlP9re2E6V2h6S+Jm1nmOp9uwVaKFDDum1nmXU9503 pU4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=YxlPOiV22RfNMQEloQv2e9ZPx45lrowLd1cOOLHxrU8=; b=RNQnf1+d54Nh5OOdCvToRzp9pCKZ0UVqs1vTR0AGLdE12zre4a0/zbdv8gAWQFSV3l Ovg/Wx7iiSeukzz2n/vvbbswScMgERpv6LFoBYfoOpIy9c/euy2or9eJX7TA3+Htpd7O Tzb4vWkomc0m5sHl4q9N3eoBG66wty7PyqOZY46j2q3T8oT0GvTipxlMytk2ewH0k1yn uMWhT4CNeTP29xPLrhc3QTHQzvAkKYj8DDFrbacYZ8UCFTb0u4cYlOqe8oNNTNRapP6V SEkbfhZj+IiadMMsI/lIlZ0ylLYvif/HHscnCHs/M+gpDzgsqR7Fk1/+5Kl1OjLuFJ8Z IUpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=dCGgTr1V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6-v6si24114892plt.328.2018.11.23.19.14.12; Fri, 23 Nov 2018 19:14:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=dCGgTr1V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389952AbeKWDYy (ORCPT + 99 others); Thu, 22 Nov 2018 22:24:54 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:44487 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389348AbeKWDYx (ORCPT ); Thu, 22 Nov 2018 22:24:53 -0500 Received: by mail-io1-f67.google.com with SMTP id r200so6990471iod.11 for ; Thu, 22 Nov 2018 08:44:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YxlPOiV22RfNMQEloQv2e9ZPx45lrowLd1cOOLHxrU8=; b=dCGgTr1V8PBHi8oIVJDOQ1IVFfJlAUkf50rik4u2/Y/KLofqvdlEtaPVZ+x6BkWV/z M/al7IMHvu8xyI2PXXjHQfxbRY3cFX+rqcbbPDm8S0GgIyf7bDIXDjgu7C1ZctvGDJQx Cv5mKF8ySNLqlkCKRmjJYsg2kkue3CN08wNtwcnb1rxJK1Nra7Hqu5Xv6CbzaJ/6O0Xu jwtX117M94xn+IHp00yI8C8NTqEb6KSYvIgxDdJJcruO0/ayn38WUUXI1j4MGb7APNwQ EcmhreAiBfxJCP+E6uGfxopmM/zv80CDUb3+c6wdaWwGxRgYT1cyMqfS5GNQm+EjopFf e5Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YxlPOiV22RfNMQEloQv2e9ZPx45lrowLd1cOOLHxrU8=; b=UI5sJTmXsoEgUOIgqgyjBSOW9uSGGtT4LXuvuSVm7LqncnWskuM5uv13/YYsZOdWIm D5VE1sgEZUGKowEH4BWGHAxqN+yip9U8xIppfYsesLyxIJ8aXqu6TVCoVUQTGJg2gP0U vvq+dBqdxBu4/8vFkoKlFGRsQfpkAnRSqSh93nzVLpXp3AQl0jDOtzvo2cYOc6IZyHXb j556dgWgrJwcgFFURJsKBII+P34pKdqwMRQcq8x+bu51ttLkR7ilLsQBntd7XZs35fS7 e6/LPEqd9DpCfA7KpZeG0YjlAedvM+TaxjVf1Y3znjkogaHuylzRJwIU9OQ9mi7L5e7o 4txQ== X-Gm-Message-State: AA+aEWb7h4vIpHKEBC39xhgMdTfMT5cveBTNdlDi9FyiT5M5CFFYhvvs wlDfICvfbRZwXIbyZN8gtForYeM0PBaLEy8WM+J7LA== X-Received: by 2002:a5e:8d13:: with SMTP id m19mr8679747ioj.258.1542905084256; Thu, 22 Nov 2018 08:44:44 -0800 (PST) MIME-Version: 1.0 References: <1542823573-20228-1-git-send-email-hofrat@osadl.org> <1542823573-20228-2-git-send-email-hofrat@osadl.org> In-Reply-To: <1542823573-20228-2-git-send-email-hofrat@osadl.org> From: Bartosz Golaszewski Date: Thu, 22 Nov 2018 17:44:33 +0100 Message-ID: Subject: Re: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack To: hofrat@osadl.org Cc: Linus Walleij , Bartosz Golaszewski , Matthias Brugger , sergio.paracuellos@gmail.com, "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux ARM , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =C5=9Br., 21 lis 2018 o 19:13 Nicholas Mc Guire napisa= =C5=82(a): > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except > for the dev_err() messages). The probe function should return an error > if one of the banks failed to initialize properly. > > Signed-off-by: Nicholas Mc Guire > Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") > --- > > Patch was compile tested with: omega2p_defconfig, SOC_MT7621=3Dy, > GPIOLIB=3Dy, GPIO_MT7621=3Dy > > Patch is against 4.20-rc3 (localversion-next is next-20181121) > > drivers/gpio/gpio-mt7621.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c > index 1ec95bc..68fca8b 100644 > --- a/drivers/gpio/gpio-mt7621.c > +++ b/drivers/gpio/gpio-mt7621.c > @@ -297,6 +297,7 @@ mediatek_gpio_probe(struct platform_device *pdev) > struct device_node *np =3D dev->of_node; > struct mtk *mtk; > int i; > + int ret; > > mtk =3D devm_kzalloc(dev, sizeof(*mtk), GFP_KERNEL); > if (!mtk) > @@ -311,8 +312,11 @@ mediatek_gpio_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, mtk); > mediatek_gpio_irq_chip.name =3D dev_name(dev); > > - for (i =3D 0; i < MTK_BANK_CNT; i++) > - mediatek_gpio_bank_probe(dev, np, i); > + for (i =3D 0; i < MTK_BANK_CNT; i++) { > + ret =3D mediatek_gpio_bank_probe(dev, np, i); > + if (!ret) > + return ret; > + } Looks like are resources allocated in mediatek_gpio_bank_probe() will be freed automatically so: Reviewed-by: Bartosz Golaszewski