Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3008429imu; Fri, 23 Nov 2018 19:14:56 -0800 (PST) X-Google-Smtp-Source: AJdET5dX6e+o8uJFv2uj+4a0v2jyMNXRA4Gwr8pMI/HMT3gY8NxkUsJP48IeZvpPBlvYJ2AB8SJJ X-Received: by 2002:a62:5881:: with SMTP id m123-v6mr18847441pfb.160.1543029296624; Fri, 23 Nov 2018 19:14:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543029296; cv=none; d=google.com; s=arc-20160816; b=Vv/TlV/W4GRt2L2AZz5e7iTIu5IsUiruzHGgd6qXXpHQPbgyLwWum4F3QUFCSeg6Cx UktRRthxDoulIfjWgX2+bBDGLs6smiLLg/OeQjkzz3gZG0vk5s8bp9G4AcczKOUDSFuY tSdbSqTXpO5X3c7zMa+GlnzjmYW9JWAeIMfnG0HL0EwfOnvAdmJ2TdQJ4oHwKzvqY5P9 1K2DxciDgkoQ+jIDHbbRp+XtSIwAbnbdsjmuGjcD6tvtc7xjYSZ4sJUcWiLP8ViEv/T8 ZT5pOC1vAw2DJm08QXgdR7qP/OKYniJVjBnbO2l3zruQMAvsJ/1uFnHFgCBngp7L5meo /RNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=PRmyzSWtXB06FJQfKje3Md4E5TZ6OkvRHlicFPLZadQ=; b=Mp0RcL9yEzxHlxJqhfr6azWn+2K3FNVqUyhBWKnC2WHEJurH7d4NyzD1+fq50u+sON S66sOfFmssWYvVPwXfyfF7+AdSJCcdNFUS6cUk+xlkK0GOvZpEHENx5bdLpypEZ3gEI9 Ri9s90Nn/TTNnhFoN5+K3CcVaarVQ4PgeVa2MaBuIlRNE0YYDbwSe0u0kM+/VMVVhbnO vBwMWIGWjcQcc+une4hTZ22B/0BfdWOOz5VBwb0JSr0Pjes/NaLUmKNQgsOjELdAlNl2 XdYaJjdGpUDEd8706iDqdgVpgRBic64r6d5TuLfvIqaMtY/C3YViE4k8XhuZpg37lEdB 9ujQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=FgwjJkVe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j65si52504569pge.444.2018.11.23.19.14.42; Fri, 23 Nov 2018 19:14:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=FgwjJkVe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438196AbeKWDTu (ORCPT + 99 others); Thu, 22 Nov 2018 22:19:50 -0500 Received: from mail-it1-f194.google.com ([209.85.166.194]:39474 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391469AbeKWDTt (ORCPT ); Thu, 22 Nov 2018 22:19:49 -0500 Received: by mail-it1-f194.google.com with SMTP id m15so14594467itl.4 for ; Thu, 22 Nov 2018 08:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PRmyzSWtXB06FJQfKje3Md4E5TZ6OkvRHlicFPLZadQ=; b=FgwjJkVeaYtB7L/Qr0qXOSJapiA21V5g3vd++N2rs+CyqZWit1l+pVHjBiqCEfhbfe ye1J7LfdIPrSvRB3p3BXDOBjCpGxpsE5znbqlusSJGr2E39JxhwnRGIeAngiEPpBmYP7 KnF1eUQShoNZyR948R3c5vjaAOd94J3KYtS5L0KCpqrujvBUgqKo5mBbNDkLusuaZont E41WTASXmwucrNU42ibLym8HlMm2HEW/A9qppBgsEPY9sopzh7f43a62wpMQkwBhV4wv 7q+3kq8cFhH9r6Oev2nDZojewf/OR+W2WYhzviXRTHUYJR9ql3a/a8ranej52gTlA+yU Xh8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PRmyzSWtXB06FJQfKje3Md4E5TZ6OkvRHlicFPLZadQ=; b=g0HCIHungnVZ6vsY4/CNF59C+uxlFJ6Hwv+rJJjLYBJu8/BdKA86T/xxp1pdMYP3sW rnsVOGGfTr6qwSJ0q9x0odnpGfoHCioGcWN0fSGeD6Zxk7cchTnYHklcsxv9VGarXhyD tQorJwomBxNmEMs9d0U2pMuMNqsrmJDKrQT9g6dsOYNVucYuzMlJvX+XM+/FEM7OChGK xA8TW8+qP+El8MIKQHp3T9dIPgVYv4JqDdTq/48ODiD2uqYjANwVVYarFpt3xkPt0DN8 w3YdEEx1wUZqDk5lYiHN+CgMxDcdJfaDjhfWapsJKDwkXGfJsN2CgFa6wKnfmaY5AuVo 4Dfg== X-Gm-Message-State: AA+aEWb9SHrtIMZ2E3S3ZCbtN/JPpMZnreyPeq8Md2qYsMhCItAWrnOC q7F2Mk1za9WZPab/Bc8vPVpr5PRq23FTPJjDpKnjJw== X-Received: by 2002:a24:f909:: with SMTP id l9mr9764991ith.74.1542904781310; Thu, 22 Nov 2018 08:39:41 -0800 (PST) MIME-Version: 1.0 References: <1542823573-20228-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1542823573-20228-1-git-send-email-hofrat@osadl.org> From: Bartosz Golaszewski Date: Thu, 22 Nov 2018 17:39:30 +0100 Message-ID: Subject: Re: [PATCH 1/2] gpio: mt7621: report failure of devm_kasprintf() To: hofrat@osadl.org Cc: Linus Walleij , Bartosz Golaszewski , Matthias Brugger , sergio.paracuellos@gmail.com, "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux ARM , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =C5=9Br., 21 lis 2018 o 19:13 Nicholas Mc Guire napisa= =C5=82(a): > > kasprintf() may return NULL on failure of internal allocation thus the > assigned label is not safe if not explicitly checked. On error > mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the > (unlikely) failure case should be fine here. > > Signed-off-by: Nicholas Mc Guire > Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") > --- > > V2: The dev_err() for the unlikely case of the devm_kasprintf() > failing was removed on request from Bartosz Golaszewski > > > Problem located with experimental coccinelle script > > Patch was compile tested with: omega2p_defconfig, SOC_MT7621=3Dy, > GPIOLIB=3Dy, GPIO_MT7621=3Dy > > Patch is against 4.20-rc3 (localversion-next is next-20181121) > > drivers/gpio/gpio-mt7621.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c > index d72af6f..1ec95bc 100644 > --- a/drivers/gpio/gpio-mt7621.c > +++ b/drivers/gpio/gpio-mt7621.c > @@ -244,6 +244,8 @@ mediatek_gpio_bank_probe(struct device *dev, > rg->chip.of_xlate =3D mediatek_gpio_xlate; > rg->chip.label =3D devm_kasprintf(dev, GFP_KERNEL, "%s-bank%d", > dev_name(dev), bank); > + if (!rg->chip.label) > + return -ENOMEM; > > ret =3D devm_gpiochip_add_data(dev, &rg->chip, mtk); > if (ret < 0) { > -- > 2.1.4 > Reviewed-by: Bartosz Golaszewski