Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3154908imu; Fri, 23 Nov 2018 22:53:08 -0800 (PST) X-Google-Smtp-Source: AFSGD/VKDXAetlwvvHNlClBvQW2vwLoaVmGkrWnQ1ZWwtTIxh1jE61rtxHEWCHDGktZT/W03zJbV X-Received: by 2002:a63:6984:: with SMTP id e126mr17215974pgc.143.1543042388166; Fri, 23 Nov 2018 22:53:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543042388; cv=none; d=google.com; s=arc-20160816; b=Uy29tkaYam1PdC3QtukKn1+Vbw2cuvsepJYQQVhXQnIJmDkMr8xhe8mM9iZMJm/Umo 6Z9kZR6tKuUHTThrr1navRatcdZuRirXQpBzF1GunUQwhoJDPzXvq6Ly51C4SgwLucrg wq4csDl+iMBHs9GVivfbWHIeCxXsdAYr+Bv4R+EqF2qJ1RYUTc6Q4QPTr0uWva2Muiqv 7Lyv1QN1EeEMBeUBhdnSMAnBF+wl3NiGbfr95J/4R/CuSyrewHq9ogAMB07ns7BpkqSg VOFx+1VTba21oUlnTWoyNkYMEazAlxFRdrlKsRUh8MOB9P6ti9SjcwIYonR4jP0fQgYa XPEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=AVbZ7ZGKlmG6zIVFr88f2YIwuqQWd//WIzMEeYGIBFA=; b=KBfhuH+vtNh64wFvsIjuGxMttvHPI2f/v/DFI8uB57+ct2b7KUuXr0JSOpYd82RIdm erGR2NbLX2PMoEjc1YzfVptMatNVzF585bCCTr33SNGfjK4KN29rgxfa+yqHpgia6fX/ BOEZiVJWHQbwLuLZ/8y/KEiQKgNWPIwRkbDCbuYV/7y8NsqR2I30+5Xh3g/VmJT/pcUY wncK+RXEGYfMVIYeWEk8ri1Uax+fgYREAEHmeTtEQ2vTazot+FuU5iF1hUZG/Bu/oqav svx7pdj71OrprFiPMVzFjgK0hYsQCKmRpdRTe69WCSw/V1NaAU4/syPahqjx7JwXgMmo yzgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1si22739504pgq.553.2018.11.23.22.52.53; Fri, 23 Nov 2018 22:53:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388335AbeKWDex convert rfc822-to-8bit (ORCPT + 99 others); Thu, 22 Nov 2018 22:34:53 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:63199 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730284AbeKWDew (ORCPT ); Thu, 22 Nov 2018 22:34:52 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 14601264-1500050 for multiple; Thu, 22 Nov 2018 16:53:36 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Daniel Vetter , LKML From: Chris Wilson In-Reply-To: <20181122165106.18238-2-daniel.vetter@ffwll.ch> Cc: Michal Hocko , Daniel Vetter , Daniel Vetter , Intel Graphics Development , DRI Development , Linux MM , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , David Rientjes , Paolo Bonzini , Andrew Morton , =?utf-8?q?Christian_K=C3=B6nig?= References: <20181122165106.18238-1-daniel.vetter@ffwll.ch> <20181122165106.18238-2-daniel.vetter@ffwll.ch> Message-ID: <154290561362.11623.15299444358726283678@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [Intel-gfx] [PATCH 1/3] mm: Check if mmu notifier callbacks are allowed to fail Date: Thu, 22 Nov 2018 16:53:34 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Daniel Vetter (2018-11-22 16:51:04) > Just a bit of paranoia, since if we start pushing this deep into > callchains it's hard to spot all places where an mmu notifier > implementation might fail when it's not allowed to. Most callers could handle the failure correctly. It looks like the failure was not propagated for convenience. -Chris