Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3163169imu; Fri, 23 Nov 2018 23:04:33 -0800 (PST) X-Google-Smtp-Source: AFSGD/WvxAFF4nIK/8o4MXOpcanAvDqkRD2gGoj20XnrJMYYinHIB5lJLNrpmOJ9l43xmZC0fe6P X-Received: by 2002:a17:902:20b:: with SMTP id 11mr16078441plc.57.1543043073181; Fri, 23 Nov 2018 23:04:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543043073; cv=none; d=google.com; s=arc-20160816; b=vKnT/4VtOBSvIpyoT4xKt+v15ul0e7FKreYDIn+3DxGzFg0Sq7+vHEzjxOzIZUjdo+ 1u6ZMaZzj5gqEU+kFsIv1UP2ROC1EhSo3Q5aMt3vqq24rMYuGolm6Rft0m33xgpq0wB3 NpM141/FeF/bN7oHCug0SSGPy+SnQ9KDfXWrP9CXYGm5MlE4YdlamfJXZZpp5w4DDLrS o31mcEApcyKp3gNFb5N+ZpI7qkn9BdB1GnbEDu7f4SsuIpvUn64drDz26l2Oyw5OeD5y JhtoopcNhmApQ1xWfl1cDFiIqiYEPCJ3r6yHSfdUMDNztQdYrCxAIbDBOTp1pWEr0/7w 1MGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jrf7hxmXp+/mRazMxpIsIPKnVpxmMQmOYGpaP0GmiYk=; b=RA9mag26dsmfmVAvDHNUU1+kyxHSRprxJsl4VhoQw+jpXtgCLym0QG04h+ULLzSstd YnZ7cD+Zp/2evdi5v8hziwzUMwuW2k0nw+lc2i8zg95TZAAVtNRtbnqnjaugnyCYHtyz 72Xy6LQtcYZBDf+SYgo3bSRZS1RVBE/OkcLSe9k3mxIc+vhtePjYj5MVjU2ExaAIRn3I tdFw1NaUvQtxvmbb1MBtZX6+Latt48pNKBzAMFcbg/+m54EcxjVNOCVGsH467olQIXoa PefAFSTrRpMlpLNwf1HtR+W5Rr9avAqILvu46VmgBMoyQ5191cblLpaPtoGdqF6WHMWQ vQMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f16si20899967pgg.173.2018.11.23.23.04.19; Fri, 23 Nov 2018 23:04:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406338AbeKWEKd (ORCPT + 99 others); Thu, 22 Nov 2018 23:10:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55960 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404220AbeKWEKc (ORCPT ); Thu, 22 Nov 2018 23:10:32 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7483230013B9; Thu, 22 Nov 2018 17:30:12 +0000 (UTC) Received: from treble (ovpn-121-105.rdu2.redhat.com [10.10.121.105]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 769F65C25A; Thu, 22 Nov 2018 17:30:06 +0000 (UTC) Date: Thu, 22 Nov 2018 11:30:04 -0600 From: Josh Poimboeuf To: Borislav Petkov Cc: Thomas Gleixner , Linus Torvalds , Linux List Kernel Mailing , the arch/x86 maintainers , Peter Zijlstra , Andrew Lutomirski , Jiri Kosina , thomas.lendacky@amd.com, Andrea Arcangeli , David Woodhouse , Andi Kleen , dave.hansen@intel.com, Casey Schaufler , "Mallick, Asit K" , "Van De Ven, Arjan" , jcm@redhat.com, longman9394@gmail.com, Greg KH , david.c.stewart@intel.com, Kees Cook , Tim Chen Subject: Re: [patch 01/24] x86/speculation: Update the TIF_SSBD comment Message-ID: <20181122173004.fn4tqoclhcyibxff@treble> References: <20181121201430.559770965@linutronix.de> <20181121201722.337599561@linutronix.de> <20181121230450.k75e4ipdag73dayz@treble> <20181121230854.GH27559@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181121230854.GH27559@zn.tnic> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 22 Nov 2018 17:30:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 22, 2018 at 12:08:54AM +0100, Borislav Petkov wrote: > On Wed, Nov 21, 2018 at 05:04:50PM -0600, Josh Poimboeuf wrote: > > Why not just 'user'? Like SPECTRE_V2_USER_*. > > Sure, a bit better except that it doesn't explain what it does, I'd say. But it does describe its purpose, especially in relation to the 'spectre_v2=' option. Previously 'spectre_v2=' might have been more appropriately named 'spectre_v2_kernel=' because it only protected the kernel from Spectre v2 attacks. Now with these new patches, 'spectre_v2=on' will protect the entire system. Whereas 'spectre_v2_user=' is a subset of that; it helps protect user space from itself. Appending "user" to the existing 'spectre_v2=' option helps to communicate that, IMO. Now off to eat a giant turkey. -- Josh