Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "acme@kernel.org" <acme@kernel.org>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH perf,bpf 0/5] reveal invisible bpf programs
Thread-Topic: [PATCH perf,bpf 0/5] reveal invisible bpf programs
Thread-Index: AQHUgdQ11TRJMN8CIkSD/uQZUfyfEaVbiN6AgACRn4A=
Date:   Thu, 22 Nov 2018 18:13:32 +0000
Message-ID: <71189F83-A09F-4A03-95EC-694D37FD7675@fb.com>
References: <20181121195502.3259930-1-songliubraving@fb.com>
 <20181122093219.GK2131@hirez.programming.kicks-ass.net>
In-Reply-To: <20181122093219.GK2131@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E56FF10F8D5FA041BE2CE94C3CE091BF@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4babe233-166e-4a31-16b4-08d650a6364d
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2018 18:13:32.3443
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1808
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-22_11:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

> On Nov 22, 2018, at 1:32 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>=20
> On Wed, Nov 21, 2018 at 11:54:57AM -0800, Song Liu wrote:
>> Changes RFC -> PATCH v1:
>>=20
>> 1. In perf-record, poll vip events in a separate thread;
>> 2. Add tag to bpf prog name;
>> 3. Small refactorings.
>>=20
>> Original cover letter (with minor revisions):
>>=20
>> This is to follow up Alexei's early effort to show bpf programs
>>=20
>>   https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__www.spinics.net=
_lists_netdev_msg524232.html&d=3DDwIBAg&c=3D5VD0RTtNlTh3ycd41b3MUw&r=3DdR86=
92q0_uaizy0jkrBJQM5k2hfm4CiFxYT8KaysFrg&m=3D3--n8O2EZfFY2WyGCKt0u4zd73778zD=
7xmoNHi9tMCU&s=3D3DY93pysLN-m1tgYmd7YAyQGNSq6KpYKucIJcB3nofc&e=3D
>>=20
>> In this version, PERF_RECORD_BPF_EVENT is introduced to send real time B=
PF
>> load/unload events to user space. In user space, perf-record is modified
>> to listen to these events (through a dedicated ring buffer) and generate
>> detailed information about the program (struct bpf_prog_info_event). The=
n,
>> perf-report translates these events into proper symbols.
>>=20
>> With this set, perf-report will show bpf program as:
>>=20
>>   18.49%     0.16%  test  [kernel.vmlinux]    [k] ksys_write
>>   18.01%     0.47%  test  [kernel.vmlinux]    [k] vfs_write
>>   17.02%     0.40%  test  bpf_prog            [k] bpf_prog_07367f7ba80df=
72b_
>>   16.97%     0.10%  test  [kernel.vmlinux]    [k] __vfs_write
>>   16.86%     0.12%  test  [kernel.vmlinux]    [k] comm_write
>>   16.67%     0.39%  test  [kernel.vmlinux]    [k] bpf_probe_read
>>=20
>> Note that, the program name is still work in progress, it will be cleane=
r
>> with function types in BTF.
>>=20
>> Please share your comments on this.
>=20
> So I see:
>=20
>  kernel/bpf/core.c:void bpf_prog_kallsyms_add(struct bpf_prog *fp)
>=20
> which should already provide basic symbol information for extant eBPF
> programs, right?

Right, if the BPF program is still loaded when perf-report runs, symbols=20
are available.=20

> And (AFAIK) perf uses /proc/kcore for annotate on the current running
> kernel (if not, it really should, given alternatives, jump_labels and
> all other other self-modifying code).
>=20
> So this fancy new stuff is only for the case where your profile spans
> eBPF load/unload events (which should be relatively rare in the normal
> case, right), or when you want source annotated asm output (I normally
> don't bother with that).

This patch set adds two pieces of information:
1. At the beginning of perf-record, save info of existing BPF programs;
2. Gather information of BPF programs load/unload during perf-record.=20

(1) is all in user space. It is necessary to show symbols of BPF program
that are unloaded _after_ perf-record. (2) needs PERF_RECORD_BPF_EVENT=20
from the ring buffer. It covers BPF program loaded during perf-record=20
(perf record -- bpf_test).=20


> That is; I would really like this fancy stuff to be an optional extra
> that is typically not needed.
>=20
> Does that make sense?

(1) above is always enabled with this set. I added option no-bpf-events=20
to disable (2). I guess you prefer the (2) is disabled by default, and=20
enabled with an option?

Thanks,
Song
=20