Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v2 1/2] bpf: add __weak hook for allocating executable memory
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
In-Reply-To: <201811230404.yavKPUOn%fengguang.wu@intel.com>
Date:   Thu, 22 Nov 2018 22:08:00 +0100
Cc:     kbuild-all@01.org, linux-arm-kernel@lists.infradead.org,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexei Starovoitov <ast@kernel.org>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Jann Horn <jannh@google.com>,
        Kees Cook <keescook@chromium.org>,
        Jessica Yu <jeyu@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <800264DE-658A-46B4-8FA1-CD1CF314AA7A@linaro.org>
References: <20181121131733.14910-2-ard.biesheuvel@linaro.org> <201811230404.yavKPUOn%fengguang.wu@intel.com>
To:     kbuild test robot <lkp@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 22 Nov 2018, at 21:01, kbuild test robot <lkp@intel.com> wrote:
>=20
> Hi Ard,
>=20
> I love your patch! Yet something to improve:
>=20

Ugh, apologies for this. I=E2=80=99m sure i build tested /something/ but cle=
arly not what i should have tested.

In any case, following up on the discussion I=E2=80=99ll have to respin this=
 in any case. I=E2=80=99ll triple check next time that what i send out was t=
ested properly.


> [auto build test ERROR on bpf-next/master]
> [also build test ERROR on v4.20-rc3 next-20181122]
> [if your patch is applied to the wrong git tree, please drop us a note to h=
elp improve the system]
>=20
> url:    https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/bpf-permit=
-JIT-allocations-to-be-served-outside-the-module-region/20181123-033144
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git m=
aster
> config: x86_64-randconfig-x002-201846 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>        # save the attached .config to linux build tree
>        make ARCH=3Dx86_64=20
>=20
> All error/warnings (new ones prefixed by >>):
>=20
>   kernel//bpf/core.c: In function 'bpf_jit_free_exec':
>>> kernel//bpf/core.c:632:24: error: 'size' undeclared (first use in this f=
unction); did you mean 'ksize'?
>     return module_memfree(size);
>                           ^~~~
>                           ksize
>   kernel//bpf/core.c:632:24: note: each undeclared identifier is reported o=
nly once for each function it appears in
>>> kernel//bpf/core.c:632:9: warning: 'return' with a value, in function re=
turning void
>     return module_memfree(size);
>            ^~~~~~~~~~~~~~
>   kernel//bpf/core.c:630:13: note: declared here
>    void __weak bpf_jit_free_exec(const void *addr)
>                ^~~~~~~~~~~~~~~~~
>=20
> vim +632 kernel//bpf/core.c
>=20
>   629   =20
>   630    void __weak bpf_jit_free_exec(const void *addr)
>   631    {
>> 632        return module_memfree(size);
>   633    }
>   634   =20
>=20
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Cen=
ter
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporat=
ion
> <.config.gz>