Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3207205imu; Sat, 24 Nov 2018 00:06:16 -0800 (PST) X-Google-Smtp-Source: AJdET5cRHavulgfbdYwXB4Hy1yYhOxSAKI64U9k8KNmsQ6FpWVqghgpblXqC5rM+I1UYl5aFoGNA X-Received: by 2002:a62:647:: with SMTP id 68-v6mr20053266pfg.42.1543046776701; Sat, 24 Nov 2018 00:06:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543046776; cv=none; d=google.com; s=arc-20160816; b=D59xaZfmVHWkXFNUzcqGD80oR5UrnRvv/5zw0UCaC+/Nt8rKbc15iceIyxaDU0TTe0 x4AqNFTVeBpDODZTzIgrlDNjspz1LnnsE/L1F9PhVF99Q55u5Pbu6ahMODuMILSGgSja vs3JiZG+LoNYmXX8giMfY4ifvBQsStL4ilPI3d15UnPjJPK2gsalASRuN/fkl/7RY9pC SI65dcDF6YKHl8AKQAHLnEC7Fl2CDObA+R9cp7enUIIaiYblUJbXFGp5c/3GYrHNrSt2 iI0I+0G6Z/xKeVuGxUjupSZ6gJDcrAuQZQKlXe9kcrqw7Y82W+LkAGBV5dbE/hFgV0p7 QoIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wC5ZqndZQIxNUggB3kL/Xa14uyqtAP7NRLqGuJMPh/U=; b=jy7zvX7ezpA6cLqoStYs6e728slWSfTjhnHzgIKnIHi9ZJrwGPu1anQzhCoI052ykL Qe5tSozPidNBY4fcTEg+LbnPodYW8Whcv4av6ZH/4p9tNKgaTcLzboLZgLkbrDmXQ3Gi 77pPf2XVNn93VBR66pWCWzQoxRsuJNCdNJxK+VonZphgqDTbE6b76Rj0x196c5A13Le+ rijbAXHYDUTXveAZq76V02n+z9Idx7P3tPPdWogdWJR9imhQiYvlzulY23uiZJTWGnIw wZhEYp5WYY8TEnmZmxxOVhqLd/834wB7BFGwBQqtjwuO+xa+tDBT7RIbgtiEyoXX1GkU 0hDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="ZX/GzxTf"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1si18516375pld.92.2018.11.24.00.06.02; Sat, 24 Nov 2018 00:06:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="ZX/GzxTf"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393416AbeKWSLq (ORCPT + 99 others); Fri, 23 Nov 2018 13:11:46 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36456 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731518AbeKWSLq (ORCPT ); Fri, 23 Nov 2018 13:11:46 -0500 Received: by mail-wr1-f65.google.com with SMTP id t3so11312388wrr.3; Thu, 22 Nov 2018 23:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wC5ZqndZQIxNUggB3kL/Xa14uyqtAP7NRLqGuJMPh/U=; b=ZX/GzxTfL8jPQm1hFB+I93oi7CY4NaDOfbbv2dB11cZrLq9BmwA1HKMMLtUF0TDDSX nP1Se6KDoE47B4q7WlasRa7W7vUxfUoKiKsF9ScBxsv8tinZiy0nLcIQ9PKAnRpCddws WpNs0t4D4UAVqINMfcSl3rsnFYxyNnwlASxf/MSCSun04yQylv51ah+QDa9HXics1XmP 9cmHBWMKzpGm4SlRMzHop5cTVqmmfzn4fxajm9yY8mVXcxrQl/wmUGfpAH9LlgUQ6mkU eAGDRJ9Ha8aU+V0XRseaegqn7hh5mPFRjr9mnQg6d7RdcEkQFyv8nYfaYDEPxsF0vLZI HufA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=wC5ZqndZQIxNUggB3kL/Xa14uyqtAP7NRLqGuJMPh/U=; b=WibSay21qhssy89Fj5Rt1iORdm+EXmFS9TYIszU+xyL1O9sIE2lyYaI2gyCgLS7PNM xVLtefdQMt9LC/HkZKwiqWPdf0jl6N5wf3Idp/53PeC+Dx5iYRbnqDos+2qWbTBJMTw/ XihJWWryg9RB4FIGWQM79EETe2YQ+fEvquihjQ6ieyFi4/QpOLczZdI1r+8pp5FauOsg fETTXvCqIn2zJiSLNmFHknCyQOw2XYgFYApOvrjhphfMzCrsPofRzWfQNxyfmL6WiB+p Ntq43yjVwxJnBDLPIP5hNxsERACiYogMZTqJvBqaQSoa+BCCaPGRIygaxdDpw89uGZn+ oRxw== X-Gm-Message-State: AA+aEWZa0Bo2LOyB0H82YoYoayxNBDjrZkVTu5JEOTKu89VxqxV0vZoS 7Y/INnMdZFhFxo1MTr9+Npc= X-Received: by 2002:adf:e509:: with SMTP id j9mr13255140wrm.76.1542958123064; Thu, 22 Nov 2018 23:28:43 -0800 (PST) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id w18sm14536391wru.54.2018.11.22.23.28.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Nov 2018 23:28:42 -0800 (PST) Date: Fri, 23 Nov 2018 08:28:39 +0100 From: Ingo Molnar To: "Moger, Babu" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "corbet@lwn.net" , "fenghua.yu@intel.com" , "reinette.chatre@intel.com" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "x86@kernel.org" , "mchehab+samsung@kernel.org" , "arnd@arndb.de" , "kstewart@linuxfoundation.org" , "pombredanne@nexb.com" , "rafael@kernel.org" , "kirill.shutemov@linux.intel.com" , "tony.luck@intel.com" , "qianyue.zj@alibaba-inc.com" , "xiaochen.shen@intel.com" , "pbonzini@redhat.com" , "Singh, Brijesh" , "Hurwitz, Sherry" , "dwmw2@infradead.org" , "Lendacky, Thomas" , "luto@kernel.org" , "joro@8bytes.org" , "jannh@google.com" , "vkuznets@redhat.com" , "rian@alum.mit.edu" , "jpoimboe@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v9 01/13] x86/resctrl: Rename and move rdt files to new directory Message-ID: <20181123072839.GA51597@gmail.com> References: <20181121202811.4492-1-babu.moger@amd.com> <20181121202811.4492-2-babu.moger@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181121202811.4492-2-babu.moger@amd.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Moger, Babu wrote: > New generation of AMD processors start supporting RDT(or QOS) > features. Together these features will be called as RESCTRL. > With more than one vendors supporting these features, it seems > more appropriate to rename these files. > > Create a new directory with the name 'resctrl' and move all the > intel_rdt files to the new directory. This way all the resctrl > related code resides inside one directory. > > Suggested-by: Borislav Petkov > Signed-off-by: Babu Moger > --- > .../x86/include/asm/{intel_rdt_sched.h => resctrl_sched.h} | 0 > arch/x86/kernel/cpu/Makefile | 5 +---- > arch/x86/kernel/cpu/resctrl/Makefile | 7 +++++++ > arch/x86/kernel/cpu/{intel_rdt.c => resctrl/core.c} | 4 ++-- > .../cpu/{intel_rdt_ctrlmondata.c => resctrl/ctrlmondata.c} | 2 +- > arch/x86/kernel/cpu/{intel_rdt.h => resctrl/internal.h} | 6 +++--- > .../kernel/cpu/{intel_rdt_monitor.c => resctrl/monitor.c} | 2 +- > .../cpu/{intel_rdt_pseudo_lock.c => resctrl/pseudo_lock.c} | 6 +++--- > .../pseudo_lock_event.h} | 2 +- > .../cpu/{intel_rdt_rdtgroup.c => resctrl/rdtgroup.c} | 4 ++-- > arch/x86/kernel/process_32.c | 2 +- > arch/x86/kernel/process_64.c | 2 +- > 12 files changed, 23 insertions(+), 19 deletions(-) > rename arch/x86/include/asm/{intel_rdt_sched.h => resctrl_sched.h} (100%) > create mode 100644 arch/x86/kernel/cpu/resctrl/Makefile > rename arch/x86/kernel/cpu/{intel_rdt.c => resctrl/core.c} (99%) > rename arch/x86/kernel/cpu/{intel_rdt_ctrlmondata.c => resctrl/ctrlmondata.c} (99%) > rename arch/x86/kernel/cpu/{intel_rdt.h => resctrl/internal.h} (99%) > rename arch/x86/kernel/cpu/{intel_rdt_monitor.c => resctrl/monitor.c} (99%) > rename arch/x86/kernel/cpu/{intel_rdt_pseudo_lock.c => resctrl/pseudo_lock.c} (99%) > rename arch/x86/kernel/cpu/{intel_rdt_pseudo_lock_event.h => resctrl/pseudo_lock_event.h} (95%) > rename arch/x86/kernel/cpu/{intel_rdt_rdtgroup.c => resctrl/rdtgroup.c} (99%) Ugh, violent NAK on this unreadable directory naming: 'resctrl' is an ugly double/triple abbreviation that nobody recognizes for what it is to begin with, and even the long form 'resource control' is an overly generic naming - *everything* the kernel does is in essence 'resource control' ... So please find some better name and standardize the namespace around it. A couple of suggestions: - 'Hardware Quality of Service', i.e. HW_QOS, hw_qos - or 'CPU bandwidth control', i.e. CPU_BW, cpu_bw - or 'Hardware Bandwidth Control', i.e. HW_BW, hw_bw etc. Thanks, ngo