Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3210364imu; Sat, 24 Nov 2018 00:10:30 -0800 (PST) X-Google-Smtp-Source: AJdET5eB2Z1A3AmO4kerDqVraIFhFTFOoHB+4VmII4oWFZhT2Sdd0CiObTpGKTUOugaUzXDlBeBz X-Received: by 2002:a62:5bc7:: with SMTP id p190-v6mr19347426pfb.175.1543047030478; Sat, 24 Nov 2018 00:10:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543047030; cv=none; d=google.com; s=arc-20160816; b=t438BIbGGmCJQVo7AtwzaXCPDP8Bpr6mtlQJ95y0gPysXBZxgxXy8LDF++y/ocRYiZ ZrvcB0c5pFF2c4duPYjgQRHFgDrqmaoJ7XCM/q7IQmNCVP+uSoYlOrd8Y8KF2bZ2Ca+X 7IMPcRmEeutNWOVOUTPpyI+CWwe5Zognp8mI2AoiaU766G0NY+WycoaFhdV/nzbAVo3n or4yVqZ5JEIJ+4xz4AxrgRP2Hen1+29NLufFR+ouDH9UmLvQxrPVcrHvNXaVt/M6ObDV YwJJO7AGN/UaNUsONzOJj7hKnhqqd9Y+apoz+WBGVl/BKRxPWVu3QIiK94Y/guQ7wNbP XEbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LZbhBSLa621/KT/AIn9+K97NVHywmP3WP6lM0VZFVdQ=; b=vsG6260wkFSS7M7QGlRAXNk63kiBPPn9kC+UZuE7UGezWTRRcgoM1DQUHsOxEHysis PlsbcCOa7dD/FdXaeAeyQ0oVOAvuljHqBQKyAPafBfCRuEmWlnUuKSYDK8goP7EQbG8B Z4bU5E26l2MBSJl83ny3DNB785UcUUxY6Wg/tMSgEpygCR0ZPdI0w912PdFxbVbGOAbf SCIUpS4Ial93wzrxKLfgtT+5n2A8IK7PavLrumpTOf0bV1HTcXXYB8E6R4ZDBd/JGE4+ Tgacm9GqroAC53F93IOx0agSpDVK6A/jcy8Wu3L4MXAodqpNaQD4XP3sqs3yRdim3W/Z d3hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=X28nRSx4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c7si40306616plz.118.2018.11.24.00.10.16; Sat, 24 Nov 2018 00:10:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=X28nRSx4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408506AbeKWTGT (ORCPT + 99 others); Fri, 23 Nov 2018 14:06:19 -0500 Received: from mail.skyhub.de ([5.9.137.197]:50700 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731828AbeKWTGT (ORCPT ); Fri, 23 Nov 2018 14:06:19 -0500 Received: from zn.tnic (p200300EC2BDC9100898E5A1DF8FAB135.dip0.t-ipconnect.de [IPv6:2003:ec:2bdc:9100:898e:5a1d:f8fa:b135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4E7591EC035B; Fri, 23 Nov 2018 09:23:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1542961386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=LZbhBSLa621/KT/AIn9+K97NVHywmP3WP6lM0VZFVdQ=; b=X28nRSx44pXZc1KgZlOqmuoxxK9Ok2EjSn8giNM4DS6dSTcXFSM2TMYLpxlHSy2ycjWUjo 6ktpzLhgklJl3B0X3ykMBnAMWn2dps6H646GZj88bvBfG3ADz/eyHERT+oFSMYsZ1iwr55 YkzHpDtBd6gPDO1T7JkeVuyNi+WPunI= Date: Fri, 23 Nov 2018 09:22:58 +0100 From: Borislav Petkov To: Ingo Molnar Cc: "Moger, Babu" , "tglx@linutronix.de" , "mingo@redhat.com" , "corbet@lwn.net" , "fenghua.yu@intel.com" , "reinette.chatre@intel.com" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "x86@kernel.org" , "mchehab+samsung@kernel.org" , "arnd@arndb.de" , "kstewart@linuxfoundation.org" , "pombredanne@nexb.com" , "rafael@kernel.org" , "kirill.shutemov@linux.intel.com" , "tony.luck@intel.com" , "qianyue.zj@alibaba-inc.com" , "xiaochen.shen@intel.com" , "pbonzini@redhat.com" , "Singh, Brijesh" , "Hurwitz, Sherry" , "dwmw2@infradead.org" , "Lendacky, Thomas" , "luto@kernel.org" , "joro@8bytes.org" , "jannh@google.com" , "vkuznets@redhat.com" , "rian@alum.mit.edu" , "jpoimboe@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v9 01/13] x86/resctrl: Rename and move rdt files to new directory Message-ID: <20181123082258.GA30697@zn.tnic> References: <20181121202811.4492-1-babu.moger@amd.com> <20181121202811.4492-2-babu.moger@amd.com> <20181123072839.GA51597@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181123072839.GA51597@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 23, 2018 at 08:28:39AM +0100, Ingo Molnar wrote: > Ugh, violent NAK on this unreadable directory naming: 'resctrl' is an > ugly double/triple abbreviation that nobody recognizes for what it is to > begin with, and even the long form 'resource control' is an overly > generic naming - *everything* the kernel does is in essence 'resource > control' ... Well, the fs this thing uses is called "resctrl". Documentation/x86/resctrl_ui.txt:1075:the resctrl will still mount but cannot create CTRL_MON directories. Documentation/x86/resctrl_ui.txt:1082:# mount -t resctrl resctrl /sys/fs/resctrl Documentation/x86/resctrl_ui.txt:1083:# cd /sys/fs/resctrl Are you saying that the fs should be renamed now too? > So please find some better name and standardize the namespace around it. > A couple of suggestions: > > - 'Hardware Quality of Service', i.e. HW_QOS, hw_qos > - or 'CPU bandwidth control', i.e. CPU_BW, cpu_bw > - or 'Hardware Bandwidth Control', i.e. HW_BW, hw_bw How are those *abbreviations* better? "hw_bw" is especially cryptic and the others are no better. "resctrl" to mean "resource control" is much better IMO. And it is different from the "other" resource controlling the kernel does because it is under arch/x86/kernel/cpu/ which tells you it is a *CPU* resource control. And also matches the user-visible "resctrl" filesystem. But I don't have the energy to bikeshed this morning so whatever, as long as it is short... -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.