Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: lightnvm: pblk: avoid ref warning on cache creation
To:     javier@cnexlabs.com
Cc:     javier@javigon.com, hans.holmberg@cnexlabs.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1542894410-14047-1-git-send-email-javier@cnexlabs.com>
 <2ef4bc58-98cf-fdfc-195d-d6f88e85f4a6@lightnvm.io>
 <2D1F9096-EFF8-43C2-8403-9897B3D36409@cnexlabs.com>
From:   =?UTF-8?Q?Matias_Bj=c3=b8rling?= <mb@lightnvm.io>
Message-ID: <cfcc4dee-c07f-156f-4523-1bda9c878b02@lightnvm.io>
Date:   Fri, 23 Nov 2018 09:23:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <2D1F9096-EFF8-43C2-8403-9897B3D36409@cnexlabs.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/23/2018 09:16 AM, Javier Gonzalez wrote:
> 
> 
>> On 23 Nov 2018, at 09.14, Matias Bjørling <mb@lightnvm.io> wrote:
>>
>>> On 11/22/2018 02:46 PM, Javier González wrote:
>>> Matias,
>>> Can you pick this up for 4.20? Even though it is not an error per se, it
>>> does trigger an ugly false positive warning when CONFIG_REFCOUNT_FULL is
>>> set.
>>> Thanks,
>>> Javier
>>> Javier González (1):
>>>    lightnvm: pblk: avoid ref warning on cache creation
>>>   drivers/lightnvm/pblk-init.c | 14 +++++---------
>>>   1 file changed, 5 insertions(+), 9 deletions(-)
>>
>> It is too late to get it for 4.20. I'll pull it in for 4.21.
> 
> Well, if it is a fix it’s not too late AFAIK. It also applies to a patch picked up in this series. We should have catches this before.
> 
> But I guess it’s your call.

There is a likelihood that Linus would catch it, with the result of fire 
& fury. I don't feel like using one of my cat life's for this one.

> 
>>
>> We can put on a Fixes: 1864de94ec9d6 "lightnvm: pblk: stop recreating global caches" if you want Greg and friends to pick picked it up for stable kernels?
> 
> I didn’t add it as it is not a bug in itself. But it is good to add it. Can you do it.
> 

I'll do it.

> Javier.
>