Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3213918imu; Sat, 24 Nov 2018 00:15:36 -0800 (PST) X-Google-Smtp-Source: AFSGD/UX84nafEe1kMXor5z0BA9qHlIX032+5T4lubhGE38MYIw0duwz15saU3yvzPehq5BhmWbR X-Received: by 2002:a65:4b82:: with SMTP id t2mr17196266pgq.189.1543047336745; Sat, 24 Nov 2018 00:15:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543047336; cv=none; d=google.com; s=arc-20160816; b=UrV33dKzqBcZmXDuJerqs56erFoHVPD/3H7opkG8cTS8LMvB6HfpuGhQvu9Eta1f/d kbNiHr6fdSuMiM3pzsikRsjXS03o8c8u95RLfzXPMd6iVUKXrcWskjXUqLck8t484KpU LC+RDKg1ZlTlroQk0jpGinI0AWXNFg8n6OwuAyCT+sWRHXgb5sYC1DnNH2W5ynQwSJmc e4NlNWzMf1mV1Q9zpfvApUSF15FymmEKndix1AS04lFXCiALQo4ly/Rp5iD5C43sHhd0 v1CS1hcL4BGWOA5SwyfUkgXu60fVWJYVLpSEm+gV7IyQX/z4vOHGNa7nLVsUexidE+QI pbBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=MRK2seu+kl05heGxfx6tAjNgSgdENwrZU0XEgnYH2Xs=; b=lSML0+5ImGYDTNplx0Dzy5F8iMsT+pf+WmBFkTONvbbwDL1nyOc1Kh5rWn6dnN4tk4 Np8wd39gAEWQexn9sPrcx0E1juKmmR8A6DiHwpcYo48Gc3FMn6QGwszI7I3BqordAPNq XyUdUCOkdlxzLMA0gWNVAR7IMmuQPWVksxmQXwJmvotOuBQXGCwBv2lwALzGedGikCNW RdXAfEng7I3hGsqOYa72Zz28Sj568sGHFreb3j/BHWK75fs/lksApk1ONlo06otJVGOj YwlO3vxcyd3UC5h2tT2RJIV7PH0VIDyyBvDGbi1HJtNi18SW02vVtTa+ibDcaS7ZfFQa SxaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1-v6si58110168pld.332.2018.11.24.00.15.22; Sat, 24 Nov 2018 00:15:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408866AbeKWT7O (ORCPT + 99 others); Fri, 23 Nov 2018 14:59:14 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:49182 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2408854AbeKWT7O (ORCPT ); Fri, 23 Nov 2018 14:59:14 -0500 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wAN90EUo019052; Fri, 23 Nov 2018 03:15:42 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail4.cirrus.com ([87.246.98.35]) by mx0a-001ae601.pphosted.com with ESMTP id 2nth989ycq-1; Fri, 23 Nov 2018 03:15:41 -0600 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail4.cirrus.com (Postfix) with ESMTP id 7A44D611C8B2; Fri, 23 Nov 2018 03:19:06 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Fri, 23 Nov 2018 09:15:40 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wAN9Fexo018505; Fri, 23 Nov 2018 09:15:40 GMT Date: Fri, 23 Nov 2018 09:15:40 +0000 From: Charles Keepax To: CC: , , , , , , , , , , , , , Subject: Re: [PATCH v5 6/8] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar Message-ID: <20181123091540.GL16508@imbe.wolfsonmicro.main> References: <20181120141631.18949-6-ckeepax@opensource.cirrus.com> <201811231606.fDWBzL7a%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <201811231606.fDWBzL7a%fengguang.wu@intel.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811230072 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 23, 2018 at 05:00:57PM +0800, kbuild test robot wrote: > Hi Charles, > > I love your patch! Yet something to improve: > > [auto build test ERROR on ljones-mfd/for-mfd-next] > [also build test ERROR on v4.20-rc3] > [cannot apply to next-20181122] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > drivers/regulator/lochnagar-regulator.c: In function 'lochnagar_micbias_of_parse': > >> drivers/regulator/lochnagar-regulator.c:115:7: error: 'LOCHNAGAR2_P2_MICBIAS_SRC_SHIFT' undeclared (first use in this function); did you mean 'LOCHNAGAR_DEVICE_ID_SHIFT'? > LOCHNAGAR2_P2_MICBIAS_SRC_SHIFT; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ These issues will resolve themselves in the merge, this patch is already merged in Mark's tree and will resolve the issue: fa2bb8b97d77 ("regulator: lochnagar: Explicitly include register headers") Thanks, Charles