Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3226402imu; Sat, 24 Nov 2018 00:32:52 -0800 (PST) X-Google-Smtp-Source: AFSGD/WX2hPiuXhcQz4FwaZg3hCedYGLeqvWyLRYfUvmA4Md+nhJFQvmX/8kTiu8CEwc0Ir1A5VZ X-Received: by 2002:a63:63c3:: with SMTP id x186mr17188149pgb.330.1543048372018; Sat, 24 Nov 2018 00:32:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543048371; cv=none; d=google.com; s=arc-20160816; b=AjsyQPlFGlUWWu/E46Wy5fAOwBNULH5Uu/u9wpQDjIoGU/EvRyo52j+DqENfcPXqLN o0qNeoCBuWs+2XdZtm4URuCp9cKiY3qF1rkbA8TH6xN4LHPU8H2jfMbeThp55kJgHf0v XxgfcSWA39vd3T5M3klMOAijz+oIKA0+vMhcV2wo036+tOy5/Rit1pZIAsaNwW/6v6W4 KGvjEaJ7nPNdUaieD///Txrf8EcppFBf4OtCfr7+/wxmMJyZEnAW0miKco+UMeSeb4wq B9QwI9mkFnP3xKonixUBxXqIrk5hQ2gFQXqlykh7uxGa+x53r1BDKEhcNBlRV1nfQEyE 0aIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=SL3Q+f4iY8pTDmB+zFDTc5VnSKgyKBr1QPuhfI0yvvY=; b=lSQe55Q/DKXTvRAGksOmNZj6famWharVF8+Ar2c2sAE+LoQYGuXbX1ibxS5tvRF3H3 Ll9+IZ6grXmoWaJeJVGLe7KbQKLIeP9p4ie54afMew103Ob+VWfwvCCOGxy9F4jsfYq8 ax0bYwT11xuIniYHuETS0C0LORDumAI1Ew/Hpjg9dSZ/5YZY76yG+ZI8lvN3w2QMUj3j Ic1RYOlFuaVX4eGqE/Mf+ZcBycX+7y3x9BuJTSH3W9xg1t7h3aoaVV4i/wRAzTKSAsF6 E5a5UiNIX0EyCcpMd1Ccb1H/qXXy5ej/LhK0EXbM//tAteHNB7dy1O8re9VKFrm2EKVG fM1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s59si16339614plb.237.2018.11.24.00.32.37; Sat, 24 Nov 2018 00:32:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504284AbeKWXeM (ORCPT + 99 others); Fri, 23 Nov 2018 18:34:12 -0500 Received: from mail.bootlin.com ([62.4.15.54]:59149 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388147AbeKWXeM (ORCPT ); Fri, 23 Nov 2018 18:34:12 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 9C8FB207BB; Fri, 23 Nov 2018 13:50:05 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id EA9DD207AB; Fri, 23 Nov 2018 13:50:04 +0100 (CET) Date: Fri, 23 Nov 2018 13:50:04 +0100 From: Boris Brezillon To: vitor Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH] i3c: master: dw: split dw-i3c-master.c into master and bus specific parts Message-ID: <20181123135004.7fd1cd58@bbrezillon> In-Reply-To: <6d513e04-3a57-1989-429c-64631101c5a2@synopsys.com> References: <20181122210202.6af50fcc@bbrezillon> <6d513e04-3a57-1989-429c-64631101c5a2@synopsys.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Nov 2018 12:39:31 +0000 vitor wrote: > Hi Boris, > > > On 22/11/18 20:02, Boris Brezillon wrote: > > On Thu, 22 Nov 2018 17:54:54 +0000 > > Vitor Soares wrote: > > > >> From: Vitor Soares > >> > >> This patch slipts dw-i3c-master.c into three pieces: > >> dw-i3c-master.c - contains the code that interacts directly with the > >> core in master mode. > >> > >> dw-i3c-platdrv.c - contains the code specific to the platform driver. > >> > >> dw-i3c-core.h - contains the definitions and declarations shared by > >> dw-i3c-master and dw-i3c-platdrv > >> > >> This patch will allow SOC integrators to add their code specific to > >> DesignWare I3C IP. > > Isn't it too early to do this change? Can't we wait until we have a SoC > > that actually embeds this IP? > > > I'm trying to turn it more flexible so the other can reuse the code. Looking at the separation you've done here, I don't see why you need it. All the resources you request are generic, so why not just adding a new compat in the of_match_table? > > > > > >> Signed-off-by: Vitor Soares > >> --- > >> drivers/i3c/master/Kconfig | 9 +- > >> drivers/i3c/master/Makefile | 5 +- > >> drivers/i3c/master/dw-i3c-core.h | 214 ++++++++++++++++++++++++++ > >> drivers/i3c/master/dw-i3c-master.c | 299 ++---------------------------------- > >> drivers/i3c/master/dw-i3c-platdrv.c | 112 ++++++++++++++ Just realized the driver is named dw-i3c-master, while the cadence driver is named i3c-master-cdns.c. I'll send a patch to make that consistent and follow the initial naming scheme: i3c-master-.c.