Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1542793169-13008-1-git-send-email-christianshewitt@gmail.com>
 <2a9d9fa9-c9ba-c624-28da-dd3804faf438@baylibre.com> <CAFW1BFzC0wzwmjvpSqb90ipY4mzdWPMc3buXjkwvi4X5e8wGJg@mail.gmail.com>
 <ea9d3fd1-068f-7bec-4166-9399d0aea02f@baylibre.com>
In-Reply-To: <ea9d3fd1-068f-7bec-4166-9399d0aea02f@baylibre.com>
From:   Michal Lazo <michal.lazo@mdragon.org>
Date:   Fri, 23 Nov 2018 14:23:30 +0100
Message-ID: <CAFW1BFwocpL3brp8h66gaAiMgcCvsr1t=tU2+oNVFNOG4DMYPQ@mail.gmail.com>
Subject: Re: [PATCH] drm/meson: add support for 1080p25 mode
To:     narmstrong@baylibre.com
Cc:     christianshewitt@gmail.com, airlied@linux.ie, khilman@baylibre.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        carlo@caione.org, linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I checked 1080p30/1080p60 and values are same
I didn't check others
so clean duplicates
or make duplicates :)


On Fri, Nov 23, 2018 at 2:15 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi Michal,
>
> On 23/11/2018 13:57, Michal Lazo wrote:
> > I would suggest same aproach as for
> > "meson_hdmi_encp_mode_1080p30"
> > and "meson_hdmi_encp_mode_1080p60"
> >
> > so duplicate "meson_hdmi_encp_mode_1080p50"
> > with name "meson_hdmi_encp_mode_1080p25"
>
> The configs are litterally the same for 1080p25 and 1080p60 unlike 1080p30/1080p60,
> so I don't see the point about duplicating a same table for the sake of naming.
>
> We will the exact same thing to support the 2160p50/2160p60 modes by reusing the
> same config are 2160p25/2160p50, and I don't see the point of duplication the
> tables here aswell.
>
> Neil
>
> >
> > now the code looks really like common copy paste problem
> > Michal Lazo
> > On Wed, Nov 21, 2018 at 10:47 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >>
> >> On 21/11/2018 10:39, Christian Hewitt wrote:
> >>> This essential mode for PAL users is missing, so add it.
> >>>
> >>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> >>> ---
> >>>  drivers/gpu/drm/meson/meson_venc.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> >>> index acbbad3..ab16046 100644
> >>> --- a/drivers/gpu/drm/meson/meson_venc.c
> >>> +++ b/drivers/gpu/drm/meson/meson_venc.c
> >>> @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode {
> >>>       { 5, &meson_hdmi_encp_mode_1080i60 },
> >>>       { 20, &meson_hdmi_encp_mode_1080i50 },
> >>>       { 32, &meson_hdmi_encp_mode_1080p24 },
> >>> +     { 33, &meson_hdmi_encp_mode_1080p50 },
> >>>       { 34, &meson_hdmi_encp_mode_1080p30 },
> >>>       { 31, &meson_hdmi_encp_mode_1080p50 },
> >>>       { 16, &meson_hdmi_encp_mode_1080p60 },
> >>>
> >>
> >> Exact, I forgot this mode...
> >>
> >> Thanks for the change !
> >>
> >> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> >>
> >> I'll add :
> >> Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and settings")
> >> when applying to drm-misc-fixes.
> >>
> >> Neil
> >>
> >> _______________________________________________
> >> linux-amlogic mailing list
> >> linux-amlogic@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> >
> >
> >
>


-- 
Best Regards

Michal Lazo
Senior developer engineer
mdragon.org
Slovakia