Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 23 Nov 2018 13:31:26 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Maxime Ripard <maxime.ripard@bootlin.com>
Cc:     Chen-Yu Tsai <wens@csie.org>, Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@googlegroups.com,
        Vasily Khoruzhick <anarsoul@gmail.com>
Subject: Re: [PATCH v9 1/8] ASoC: dt-bindings: sun50i-codec-analog: Add
 headphone amp regulator supply
Message-ID: <20181123133126.GF2089@sirena.org.uk>
References: <20181122102325.29495-1-wens@csie.org>
 <20181122102325.29495-2-wens@csie.org>
 <20181122153241.lzrwhkewg5q4hy2c@flea>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tWc6BTYdre847SEs"
Content-Disposition: inline
In-Reply-To: <20181122153241.lzrwhkewg5q4hy2c@flea>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--tWc6BTYdre847SEs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 22, 2018 at 04:32:41PM +0100, Maxime Ripard wrote:
> On Thu, Nov 22, 2018 at 06:23:18PM +0800, Chen-Yu Tsai wrote:

> > +- cpvdd-supply: Regulator supply for the headphone amplifier

> I guess we should make this optional, since even if it's missing, it's
> going to create a dummy regulator. and that allows to have backward
> compatibility.

Regulators should never be marked as optional unless they can be
physically absent.  It is true that Linux has code to handle partially
defined device trees but we shouldn't rely on other OSs having similar
code and it's better practice to have board device trees be fully
specified, it means that if we need the regulator information for some
future thing it's more likely to be there and it's less likely that bugs
which do things like cause the regulator to be powered off incorrectly
will be introduced in future.

--tWc6BTYdre847SEs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlv4AS4ACgkQJNaLcl1U
h9AYIggAhg//WqT0GsO27SLAihrkB6m9aDOYxbNLf16kxManjIHvCNpKAyuOc+bn
Go+pZkE9hZ83rkO86bfA5fMjkJnkjVmt8/k0nGyJqm9vH7jXh9qW9R7pBhCazgvG
Pd9Va3ouJXI/HhcECJApYMPXS+DOn9fdS/HUeXcF5FyhEAbVwUsD7l3CZFxgO8n3
kzVevvyicXzRaYnnSJZMUBQM9INkFwAaPXBzLoYNre86eA/ktc//e4zXCVh1PMwx
D2cExRRexfpU6QjlCvivVGYY5Qxk4qPMsmdaKD5b94HkVgFszXKjPHqOLobQ2wIA
w02xpmRW28FVH2vYd/FlOHRfrMGzdQ==
=9LaI
-----END PGP SIGNATURE-----

--tWc6BTYdre847SEs--