Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3230922imu; Sat, 24 Nov 2018 00:38:52 -0800 (PST) X-Google-Smtp-Source: AFSGD/W9uamtVTrZevKXCUB7u2KjrSSudR9uYoFgNSpxzdFkzzF0kZxS54usTk2ZVYGEFDK1TrA9 X-Received: by 2002:a63:1e17:: with SMTP id e23mr17003976pge.130.1543048732863; Sat, 24 Nov 2018 00:38:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543048732; cv=none; d=google.com; s=arc-20160816; b=dbMBnkJbeF9pajzqF31DBxqQjPAEpUbr2CMgCb6+SziKxh1FZcC1Xz9w5vc9mkSkyN rPZVT69slsu9Q/A6jB24nT59E8z+pXwUpYufy3R/ivsYvObKeyH2hNPDUPQEumMHe8bx acpxK6+IQeds25LWvzlovj+n/EixgcBP4GSqht2FG6NaJ8NHFS95NCVZwl+N2awFYi86 w0N+OtNyqhwEDTz2zK0Gzelp1Buh6Gp0G4pf+c3pWaneuFQ/5HuMua2MhjRWS0tVhTS4 dQplGnifc0RJ9b8fdwZ4m6jBROwzX9MRpo4kpXW5AvNekQVvabRGL2zdct6jzj4xNL0g Do/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=txTSGU3R3+BNWxxXQnoEkQSDROBOwx3DJKmyf83ucjY=; b=045Sa7D+90N2Do9RcTT7vQ5J2kZalh+D2Gluj4m7TKmgdLcz3cYs2RNUjq5ETv7sBy 9txO/r6wgVlxaH0rDSDb2tsSKBXcIPUpOlDG+tZHXFikz/B0xalQ7NbWe6xspKVrhZwc btsEgpse4utUEZdpBxWvWdn2Ujy9+VT/GTPSkAxJhBXTUqnMp6gj9xUMr+6ZMXqLUceX 1QC2L3LiIjMYQXt+G1vR4i9qCI7ItlTNVWFEI8p6LD3Ryep3owOfs+NPlNN+j1PkFDDO smJpfXsIzkodPRhsji12TW23+SNQnPZ+iUPaWTx48I6mRuizPFpT/+IFEOqGLES44qn9 7Qkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=MgbR7c7z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si24289839pgf.52.2018.11.24.00.38.38; Sat, 24 Nov 2018 00:38:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=MgbR7c7z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440108AbeKXB2D (ORCPT + 99 others); Fri, 23 Nov 2018 20:28:03 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:35986 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731421AbeKXB2C (ORCPT ); Fri, 23 Nov 2018 20:28:02 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wANEcebr179230; Fri, 23 Nov 2018 14:43:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=txTSGU3R3+BNWxxXQnoEkQSDROBOwx3DJKmyf83ucjY=; b=MgbR7c7zw/uNJQfM3gTXDqCeyXHi4JiU7GFCsCoC6PUtkKhWX5d8f8tOJTv0cEmyN6Fw kaUne3TLdpDd6ecn/ViglTnB5bJKHvtxiycLv9wC//xDama0B+hDwLUxM7fs2BEqaE7j zbaYCDu+Ucn7JVFBXMaHS1KIwVNouL8PDbLeOKuC2N3lyYI+ceRV/0rjyq01gfm+C5eZ ecs9j/lUFD9HYOm0/wNADS7c14KzaOU18oNf/Da8j72NQF+l0RSJj0q2hVHeL1xfGp+w JLmvut6ZrtyTQtjOY3tthNYndNb35Sd3IND1U0z6r13dp5CZtz2ApszzHJmQgNSBFjhv qQ== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2ntadub85a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Nov 2018 14:43:25 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wANEhJrn009404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Nov 2018 14:43:19 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wANEhIig031170; Fri, 23 Nov 2018 14:43:18 GMT Received: from unbuntlaptop (/10.175.219.215) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 23 Nov 2018 06:43:17 -0800 Date: Fri, 23 Nov 2018 17:43:07 +0300 From: Dan Carpenter To: Minas Harutyunyan Cc: Marek Szyprowski , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , Greg Kroah-Hartman , Felipe Balbi , Geert Uytterhoeven , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect" Message-ID: <20181123144307.GC2970@unbuntlaptop> References: <20181121154504.13052-1-m.szyprowski@samsung.com> <410670D7E743164D87FA6160E7907A56013A7AA1EE@am04wembxa.internal.synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <410670D7E743164D87FA6160E7907A56013A7AA1EE@am04wembxa.internal.synopsys.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9085 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=548 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811230122 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ugh... We also had a long thread about the v2 patch but it turns out the list was not CC'd. I should have checked for that. You have to pass a flag to say if the caller holds the lock or not... regards, dan carpenter