Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 23 Nov 2018 14:25:44 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     linus.walleij@linaro.org, lgirdwood@gmail.com,
        m.szyprowski@samsung.com, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com
Subject: Re: [PATCH 2/3] regulator: Only free GPIOs if the core requested them
Message-ID: <20181123142544.GI2089@sirena.org.uk>
References: <20181122173015.23905-1-ckeepax@opensource.cirrus.com>
 <20181122173015.23905-2-ckeepax@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="17Nf1kE0PuD3oAGS"
Content-Disposition: inline
In-Reply-To: <20181122173015.23905-2-ckeepax@opensource.cirrus.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--17Nf1kE0PuD3oAGS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 22, 2018 at 05:30:14PM +0000, Charles Keepax wrote:
> Currently, the regulator core will take ownership of any GPIO passed
> into it. Makes end driver code fairly error prone as the normal devm_
> patterns of allocation don't work. Update the regulator core to only
> free the GPIO if it requested it, this allows the drivers to manage the
> GPIO lifetime as they normally would.

I think this is fine in conjunction with patch 3 in that adding that
patch sorts out the double free problems with shared regulators but
without that pushing the GPIO management into the individual regulator
drivers is going to create trouble as something needs to coordinate to
make sure that we only free when the last user is gone.

However even with patch 3 I think it'd be better to base this off the
rest of Linus' series for converting to descriptors (which is currently
sitting waiting for some more testing) since that will convert
everything to descriptors and so remove the code that's doing requests
in the core entirely.

--17Nf1kE0PuD3oAGS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlv4DecACgkQJNaLcl1U
h9Cmqgf/esCjGRhqFLJVPAdbeVYlbTV0n6/iiEzwFXn5UfVle7ljW3KJ24tOTDqA
sYK6H++Qs3JyXOwexI8/mxkjIqUfCOOCIsqSJcp//3BBgTKp0PcyuXmKvQ8qmaRp
twohfzOskKGaQmITcCJ3RtRsN1FlgVnd/5um1KrIC9f6EZDu9Jdj7JaBEdZjp40a
0gRDzhx70m9TA8h1zdsZJ9VJKKngTumogT/BAd5b3RQJCZ8B2JrCgSx+TGBcWbHw
TKcxr1K6kBrAA/+/NvEcHTDA8sn1TsEbS2Dfbk2YQEX7/AQ7PWpk83TvhAxFTcTr
RtNRQ6UkajgYQe6rQEUxg9/cSN35yQ==
=pxdb
-----END PGP SIGNATURE-----

--17Nf1kE0PuD3oAGS--