Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yury Norov <ynorov@caviumnetworks.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Norov, Yuri" <Yuri.Norov@cavium.com>,
        Clement Courbet <courbet@google.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Matthew Wilcox <mawilcox@microsoft.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: [PATCH] find_bit_benchmark: align test_find_next_and_bit with others
Thread-Topic: [PATCH] find_bit_benchmark: align test_find_next_and_bit with
 others
Thread-Index: AQHUg1S3l6LZVyjzDUS6OC9cPmo1Kw==
Date:   Fri, 23 Nov 2018 17:48:17 +0000
Message-ID: <20181123174803.10916-1-ynorov@caviumnetworks.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [50.233.148.155]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;BYAPR07MB5782;6:d6GQR3llg2FIfdK5k4jt6Qa0/Jc0NHZjnZ6v3O6MUbEBmu7cDl/E40bmRY40JTY31cwiJeUMVhWTK4/Htp1vKpIBesbAKUo9vK+pJFx5Mj64YeKPcjOzLBUONBnRdUysZ7vOuAupb4oEHTnbC54KKkSeG82ClZQyVI9HKoZXkEbPltRUPayJf1/HixchTpNGM++h84F3QeUoxzQfs+h3u3sN57q4clsWOgUd3RzL8xjZsiGWN27O86zhYTJCwmIELOqg6/g8fTRgQ7aa8rrgSliIHlwX1jIba38lp4tVPnO2qvUuJCILZwwlK+fmCDEbiZ1deA4F0Qw5IHJSB18MYq3qnoV2IGeFczWmmR2HeWmjNaCau6UJDp6jXSYWbhqThkDC/9RdR5R7VUPzASWhz8iQLvR7BaXm1VKkfnT92zYf1EYJCJw38QJiSyp4e6c90FJBCAnNA8Qov1DLiVMkkw==;5:4adNW+kVJ1S7dV8WK8n1q8EGQkbnICC2KWDWMdlT5Z9WP3zpL9WShRKl1Bycs1ABiGrMT1iZXpoEbHcWe83Htrdv+dxYmhMAG1J6z15To09StAHU8VxAytpH1Y+fuRedJRhTeu1bf4We2LRriYTcPrIN6sjrjWaYqZ5BJGt24HY=;7:qJCjlRsNmo40JAMxA12x6UuIFkKsEhNOe4/m0IjXSWK6UxQ7jClYkWYGX8hRjcS2PiKkPgwl0fxuAL4fDt3eYXc8IWYJOnWYWAud0ZyBdfuXS9BImKzknXc+18Sl3/7MXzmAX3tvzlDRkCZuhI3+Iw==
x-ms-office365-filtering-correlation-id: 989cc0f6-b611-4bcd-d3a8-08d6516bd983
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:BYAPR07MB5782;
x-ms-traffictypediagnostic: BYAPR07MB5782:
x-microsoft-antispam-prvs: <BYAPR07MB57829A2459866810AC2E4E67E3D40@BYAPR07MB5782.namprd07.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3231442)(944501410)(52105112)(3002001)(148016)(149066)(150057)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095);SRVR:BYAPR07MB5782;BCL:0;PCL:0;RULEID:;SRVR:BYAPR07MB5782;
x-forefront-prvs: 086597191B
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(136003)(376002)(396003)(39860400002)(366004)(199004)(189003)(5660300001)(68736007)(6512007)(110136005)(476003)(53936002)(2501003)(386003)(6506007)(99286004)(6486002)(14454004)(316002)(305945005)(2616005)(71200400001)(71190400001)(52116002)(1076002)(54906003)(25786009)(42882007)(81166006)(106356001)(66066001)(105586002)(81156014)(72206003)(6436002)(575784001)(36756003)(478600001)(256004)(1857600001)(8936002)(2906002)(4326008)(97736004)(8676002)(2900100001)(7736002)(102836004)(486006)(186003)(26005)(3846002)(6116002)(39060400002);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR07MB5782;H:BYAPR07MB4373.namprd07.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: POZSTEIBA6C1uBwjlsw+9S0oDwZaeOklaCHlsHNEZu7oP58qiJhtlRhhsJtZwuhpgEAyhu42sEnNIi2qTzZ35wRJe+/pZaQMO2De2C2JRFf3heDT2ZiQ6FQ9NG938EqstqDOBZhdrZfFHnFjnEZ6xMYzb8V7MKaquldBWSsgqmxWqF/K+xCbztEDgSFREj8+fc2lSuDLJuXgimCUVnBdHJ5zs4ttz6dmMQXmWs6JraVAz4+B6jVRuRJI+NPS7JbCN39mmhLfaUZIxwymJt0C0lBFBdck0fxTckQhlh2H0ZpeOA148+RcX07pKli92SQ6Ld16PgyFZ4lTb35SLvciiqtzBiOFei4nXX26nloPMJU=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 989cc0f6-b611-4bcd-d3a8-08d6516bd983
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2018 17:48:17.8868
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5782
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In contrary to other tests, the test_find_next_and_bit uses tab
formatting in output and get_cycles() instead of ktime_get().
get_cycles() is not supported by some arches, so ktime_get()
fits better in generic code.

Fix it and minor style issues, so the output looks like this:

Start testing find_bit() with random-filled bitmap
find_next_bit:                 7142816 ns, 163282 iterations
find_next_zero_bit:            8545712 ns, 164399 iterations
find_last_bit:                 6332032 ns, 163282 iterations
find_first_bit:               20509424 ns,  16606 iterations
find_next_and_bit:             4060016 ns,  73424 iterations

Start testing find_bit() with sparse bitmap
find_next_bit:                   55984 ns,    656 iterations
find_next_zero_bit:           19197536 ns, 327025 iterations
find_last_bit:                   65088 ns,    656 iterations
find_first_bit:                5923712 ns,    656 iterations
find_next_and_bit:               29088 ns,      1 iterations

Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
---
 lib/find_bit_benchmark.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/lib/find_bit_benchmark.c b/lib/find_bit_benchmark.c
index 5367ffa5c18f..f0e394dd2beb 100644
--- a/lib/find_bit_benchmark.c
+++ b/lib/find_bit_benchmark.c
@@ -108,14 +108,13 @@ static int __init test_find_next_and_bit(const void *=
bitmap,
 		const void *bitmap2, unsigned long len)
 {
 	unsigned long i, cnt;
-	cycles_t cycles;
+	ktime_t time;
=20
-	cycles =3D get_cycles();
+	time =3D ktime_get();
 	for (cnt =3D i =3D 0; i < BITMAP_LEN; cnt++)
-		i =3D find_next_and_bit(bitmap, bitmap2, BITMAP_LEN, i+1);
-	cycles =3D get_cycles() - cycles;
-	pr_err("find_next_and_bit:\t\t%llu cycles, %ld iterations\n",
-		(u64)cycles, cnt);
+		i =3D find_next_and_bit(bitmap, bitmap2, BITMAP_LEN, i + 1);
+	time =3D ktime_get() - time;
+	pr_err("find_next_and_bit:  %18llu ns, %6ld iterations\n", time, cnt);
=20
 	return 0;
 }
--=20
2.17.1