Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3238658imu; Sat, 24 Nov 2018 00:49:25 -0800 (PST) X-Google-Smtp-Source: AJdET5eLsyAVUKquM1onIyAbEluHCX7QODEUSswMCkIbMUvkr9wI0zAWaM/ci9Sh4FWRkMnjupKH X-Received: by 2002:a62:5716:: with SMTP id l22mr19011119pfb.16.1543049365713; Sat, 24 Nov 2018 00:49:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543049365; cv=none; d=google.com; s=arc-20160816; b=L0hSVfvS/3aer/UBIBwacwtZpp+JlkRLM9ozGpQp0ASu2nleJecKZXQ0W8cpdZzw7K vEptJHQZZq8rVVK4BDyQxAgDLlM1cL/rBbL3Mgva7kr7tzvFbb1ta1gqToWXmycrnmg5 xXURsIxVgJxWQDgnqHGxnIPyRRcKn5GF4wQr3SqfzsEDsmqcH40ar0i6barMiKCBh9tH VtQOOituoKLcFJTV50b4PcS6RwmeUdUa0wx6fLW2Gql1A8PrMSD+bIl0UPaC3Lnpw2zV LmH3O+B9XIq2sATRr/5hQ3pflhM3bnH0tgIPSC8vWGjFGH12R47u0Sl4pAoJOJcpuZId IbhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=0EHgHrUwN+QIJK/PrVSm9Qj59ypND7Y5Yw0OiGOjF1Y=; b=XJ3F4bSWz6SHO2wiUP/ovTvUVWm/42+8a3hVYJEMI2kXIqV/j7x3pE3wZlZV+Wz4mU 01hUcj85Aue0ahNy2lQBcehwk2aNRab3MfzEm3GDYfahJO0iAQvAuPzDoQ1WRpNQn1i3 0gPrkhnmnwjt+pGQ8ejfFR1MtWB3xDGvbUXa+NPnEjTa6YcHGanQrLTcDWUS8D1zoTUO 3QEz1fW6RNI0Q5gh0JIgvHtUyvn0UnrfjVduyR6D6JYYT+X9da987CY14oPpP7mA3sJL 8bjWtUrhOkQCI6GuZUtBAigRslsqpJmfm7etIP0hxCvzb0/7dS7sEQWU9I2fn/qae4pQ tyHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w16si54470721pga.328.2018.11.24.00.49.11; Sat, 24 Nov 2018 00:49:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391757AbeKXGKo (ORCPT + 99 others); Sat, 24 Nov 2018 01:10:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:53234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbeKXGKo (ORCPT ); Sat, 24 Nov 2018 01:10:44 -0500 Received: from vmware.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 124AB20874; Fri, 23 Nov 2018 19:25:06 +0000 (UTC) Date: Fri, 23 Nov 2018 14:25:04 -0500 From: Steven Rostedt To: Joel Fernandes Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Masami Hiramatsu , Josh Poimboeuf , Frederic Weisbecker , Andy Lutomirski , Mark Rutland Subject: Re: [RFC][PATCH 09/14] function_graph: Move ftrace_graph_get_addr() to fgraph.c Message-ID: <20181123142504.5c748c93@vmware.local.home> In-Reply-To: <20181123031338.GC17060@google.com> References: <20181122012708.491151844@goodmis.org> <20181122012803.843285508@goodmis.org> <20181123031338.GC17060@google.com> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Nov 2018 19:13:38 -0800 Joel Fernandes wrote: > On Wed, Nov 21, 2018 at 08:27:17PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > Move the function function_graph_get_addr() to fgraph.c, as the management > > of the curr_ret_stack is going to change, and all the accesses to ret_stack > > needs to be done in fgraph.c. > > s/ftrace_graph_get_addr/ftrace_graph_ret_addr/ > Good catch. I wrote the change logs a bit after writing the patch. I had "get" on my mind. -- Steve