Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3243496imu; Sat, 24 Nov 2018 00:56:06 -0800 (PST) X-Google-Smtp-Source: AJdET5dQMeMKF2gilV/7T7KEUHidT0gxcqzg0OdYxqQssS4jZQLwTBOJnO+cAWEaOwj15mLB/p05 X-Received: by 2002:a62:870e:: with SMTP id i14mr19815212pfe.41.1543049766455; Sat, 24 Nov 2018 00:56:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543049766; cv=none; d=google.com; s=arc-20160816; b=S/3mWCDkCTpZ4mpdeL7g1TDbbJlo/FQNVKsCgA+CfznfQkO/3sKrlrip4jqMGMF+tf Xk42+4/9NaGOqdxq+dJ6qYhcV1W6/W8g9gsYTM0sC5Ak/OpOoS5rgENn+PDnpJ8iEdFk dHEPUhadGEKb//KkBtO1rEv/heAfLIXIxh1myJtDndLifxbiick+khAWQkDFuWPlCNkL iU0gyTvaPy5HEijgP0zS/KaZMkhThcq5EpPTG6Tt6cPpmcS7ROBJ+RBCZlUiy7g5/tTW xOakToaRsYNDf3d6NB9+JGYhhVYJk7nQvwyPvxrWuIJnL/tG4PCh06IEfjnSB6SeFKXJ I+9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Uf/WAfE3B1wbeNo7KuTlgIOqdhNQhE/F5EuUA7fePpQ=; b=CaFRd6VPSMPtpW9lxl5qxuRhFsX3tHuUrsYutPyawwigIQU0U1bKn1mutc7rckI2Dz 93DPkWhDAnqnB3i3i2/ApaD4aO8dg3bCkfW+P96Ca7zL1lRfHyceu3nA8TkT1yD9c83i o/FJz5lX4ebCTOJ/k72TT/qIUbbds0NIGXYNGuiLx55H+b967W+Lf029fL5X77N2svg7 xokfluIWH4I860T9rOfr/J8Fy2fynxb4Z5nTnaT+t2wVb73iuIBD5uJHbs6WwKW0WjEm bu4DMEKcO3ip3LZ29Bm8kp34HaNeAzTuB0cZR8G7y0jN4nIFfkakyOZPmqCexJtqpxyZ Rr8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5si10029269plt.5.2018.11.24.00.55.52; Sat, 24 Nov 2018 00:56:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728771AbeKXMEJ (ORCPT + 99 others); Sat, 24 Nov 2018 07:04:09 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38800 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728578AbeKXMEJ (ORCPT ); Sat, 24 Nov 2018 07:04:09 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3820314D7586B; Fri, 23 Nov 2018 17:17:40 -0800 (PST) Date: Fri, 23 Nov 2018 17:17:31 -0800 (PST) Message-Id: <20181123.171731.492917868945579642.davem@davemloft.net> To: yuehaibing@huawei.com Cc: thomas.petazzoni@bootlin.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: mvneta: remove redundant check for eee->tx_lpi_timer < 0 From: David Miller In-Reply-To: <20181122064200.11572-1-yuehaibing@huawei.com> References: <20181122064200.11572-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 23 Nov 2018 17:17:40 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Thu, 22 Nov 2018 14:42:00 +0800 > fixes the smatch warning: > > drivers/net/ethernet/marvell/mvneta.c:4252 mvneta_ethtool_set_eee() warn: > unsigned 'eee->tx_lpi_timer' is never less than zero. > > Signed-off-by: YueHaibing Applied.